Skip to content

test: add test for sequence#4868

Open
Gobot1234 wants to merge 7 commits intomainfrom
jhilton/test-sequence-in-settings-api
Open

test: add test for sequence#4868
Gobot1234 wants to merge 7 commits intomainfrom
jhilton/test-sequence-in-settings-api

Conversation

@Gobot1234
Copy link
Copy Markdown
Collaborator

Context

There were no tests for abitary sequence classes in the settings api

Change Summary

Add a test for it

Impact

Just tests

Copilot AI review requested due to automatic review settings January 28, 2026 10:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds test coverage for arbitrary sequence classes in the settings API, specifically testing the ability to use sequence-like objects (such as UserList) when copying boundary conditions.

Changes:

  • Added a new test function test_sequence_attributes to verify that sequence types work correctly with the settings API's copy method
  • Added imports for UserList and Solver to support the new test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_settings_api.py Outdated
@github-actions github-actions bot added the maintenance General maintenance of the repo (libraries, cicd, etc) label Jan 28, 2026
@Gobot1234 Gobot1234 changed the title maint: add test for sequence test: add test for sequence Jan 28, 2026
@github-actions github-actions bot added the enhancement Improve any current implemented feature label Jan 28, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 29, 2026 09:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread doc/changelog.d/4868.test.md
@Gobot1234
Copy link
Copy Markdown
Collaborator Author

Failures look unrelated

Copilot AI review requested due to automatic review settings March 30, 2026 12:00
@Gobot1234 Gobot1234 enabled auto-merge (squash) March 30, 2026 12:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_settings_api.py
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 1, 2026 08:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@Gobot1234 Gobot1234 closed this Apr 2, 2026
auto-merge was automatically disabled April 2, 2026 13:38

Pull request was closed

@Gobot1234 Gobot1234 reopened this Apr 2, 2026
@Gobot1234 Gobot1234 enabled auto-merge (squash) April 2, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improve any current implemented feature maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants