Integrate Vulkan Screenshot Layer with Perfetto#11
Merged
m--koma merged 23 commits intoandroid-graphics:mainfrom Apr 17, 2026
Merged
Integrate Vulkan Screenshot Layer with Perfetto#11m--koma merged 23 commits intoandroid-graphics:mainfrom
m--koma merged 23 commits intoandroid-graphics:mainfrom
Conversation
m--koma
requested review from
emrekultursay and
olehkuznetsov
and removed request for
olehkuznetsov
Author
|
Looks like Perfetto upgrade breaks some of the CI checks; I'll look into it. |
m--koma
force-pushed
the
perfetto_screenshot_clean
branch
3 times, most recently
from
6c08a49 to
084d9dd
Compare
m--koma
force-pushed
the
perfetto_screenshot_clean
branch
from
084d9dd to
269aa4c
Compare
Author
|
The CI is now green on this PR. Changes to fix it are in commits 4 and 5. |
emrekultursay
approved these changes
Apr 16, 2026
m--koma
commented
Apr 17, 2026
Author
m--koma
left a comment
m--koma
left a comment
There was a problem hiding this comment.
Not used to large reviews on Github, just saw that apparently I have 41 comment pending.
m--koma
force-pushed
the
perfetto_screenshot_clean
branch
from
77066c7 to
8163eb0
Compare
olehkuznetsov
approved these changes
Apr 17, 2026
olehkuznetsov
left a comment
olehkuznetsov
left a comment
There was a problem hiding this comment.
I think it is mostly good from functional point of view.
Some code clean up still can be made.
Before submitting we need to verify those cases:
- App with layer started before perfetto
we record two perfetto sessions while app is running
in both perfetto files we can see screenshots. - Perfetto started before app and app finishes first.
- Perfetto started before app and perfetto stops first.
m--koma
force-pushed
the
perfetto_screenshot_clean
branch
from
b865a14 to
726cecc
Compare
Author
|
Tested all three cases (4 traces), appear to work ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates the Vulkan screenshot layer with the Perfetto SDK, allowing screenshots to be emitted directly into Perfetto traces.
Key changes:
perfetto.ccandperfetto.hto include changes from PR #5348, which adds .pam and .ppm data formats. This was from a local fetch of Perfetto as this change has not been released yet.clang-formatonscreenshot.cppto align with project style guidelines.ScreenshotDataSourceto handle emission.screenshot_layer.mdwith instructions on how to build and verify this feature on Android.Perfetto SDK update and clang are in separate commits for easier review.
Verification: