Skip to content

Support preserving space#4

Merged
Veetaha merged 10 commits intoamredev:mainfrom
Veetaha:feat/preserve-space
Aug 2, 2025
Merged

Support preserving space#4
Veetaha merged 10 commits intoamredev:mainfrom
Veetaha:feat/preserve-space

Conversation

@Veetaha
Copy link
Copy Markdown
Member

@Veetaha Veetaha commented Jul 21, 2025

No description provided.

@Veetaha Veetaha requested a review from Copilot July 31, 2025 01:03
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements support for preserving space in the decondenser formatting tool. The main purpose is to allow the formatter to maintain the original spacing from input while still providing the ability to control and constrain space sizes through configuration.

Key changes:

  • Refactored space handling to support preserving input spacing with configurable size constraints
  • Added new unescaping functionality with comprehensive escape sequence support
  • Restructured the configuration system and removed the escape sequences feature

Reviewed Changes

Copilot reviewed 35 out of 38 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
decondenser/tests/integration/main.rs Updated test file references and added indent configuration support
decondenser/tests/integration/formatting.toml Updated test formatting configuration with new expected outputs
decondenser/src/lib.rs Major API restructuring with new visual size abstraction and indent handling
decondenser/src/space.rs New space configuration system supporting size ranges and breakability
decondenser/src/str.rs Implemented small string optimization with inline storage
decondenser/src/unescaping/ New comprehensive unescaping module with multi-language support
decondenser/src/visual_size.rs New visual size measurement abstraction
decondenser/src/formatting/mod.rs Refactored formatting engine to handle preserved spacing
decondenser/src/config.rs Simplified configuration removing escape sequences
Comments suppressed due to low confidence (1)

decondenser/src/unescaping/l1.rs:107

  • The method call self.next() should be self.cursor.next() to be consistent with the cursor usage pattern in the rest of the function.
        self.next();

Comment thread decondenser/src/lib.rs
Comment thread decondenser/src/str.rs Outdated
Comment thread decondenser/src/str.rs Outdated
Comment thread decondenser/src/config.rs
@Veetaha Veetaha merged commit 9c11bdb into amredev:main Aug 2, 2025
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants