Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for preserving space in the decondenser formatting tool. The main purpose is to allow the formatter to maintain the original spacing from input while still providing the ability to control and constrain space sizes through configuration.
Key changes:
- Refactored space handling to support preserving input spacing with configurable size constraints
- Added new unescaping functionality with comprehensive escape sequence support
- Restructured the configuration system and removed the escape sequences feature
Reviewed Changes
Copilot reviewed 35 out of 38 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| decondenser/tests/integration/main.rs | Updated test file references and added indent configuration support |
| decondenser/tests/integration/formatting.toml | Updated test formatting configuration with new expected outputs |
| decondenser/src/lib.rs | Major API restructuring with new visual size abstraction and indent handling |
| decondenser/src/space.rs | New space configuration system supporting size ranges and breakability |
| decondenser/src/str.rs | Implemented small string optimization with inline storage |
| decondenser/src/unescaping/ | New comprehensive unescaping module with multi-language support |
| decondenser/src/visual_size.rs | New visual size measurement abstraction |
| decondenser/src/formatting/mod.rs | Refactored formatting engine to handle preserved spacing |
| decondenser/src/config.rs | Simplified configuration removing escape sequences |
Comments suppressed due to low confidence (1)
decondenser/src/unescaping/l1.rs:107
- The method call
self.next()should beself.cursor.next()to be consistent with the cursor usage pattern in the rest of the function.
self.next();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.