Remove details.documents from mandatory fields of publication [WHIT-1922]#4014
Merged
patrickpatrickpatrick merged 3 commits intomainfrom Apr 21, 2026
Merged
Remove details.documents from mandatory fields of publication [WHIT-1922]#4014patrickpatrickpatrick merged 3 commits intomainfrom
details.documents from mandatory fields of publication [WHIT-1922]#4014patrickpatrickpatrick merged 3 commits intomainfrom
Conversation
patrickpatrickpatrick
changed the title
documents from details of publicationdocuments from details of publication [WHIT-1922]
patrickpatrickpatrick
force-pushed
the
remove-documents-from-details
branch
4 times, most recently
from
cb7a015 to
faddf07
Compare
patrickpatrickpatrick
changed the title
documents from details of publication [WHIT-1922]documents from mandatory fields of publication [WHIT-1922]
patrickpatrickpatrick
changed the title
documents from mandatory fields of publication [WHIT-1922]details.documents from mandatory fields of publication [WHIT-1922]
AgaDufrat
reviewed
Apr 17, 2026
| uses: alphagov/whitehall/.github/workflows/minitest.yml@main | ||
| with: | ||
| ref: 'main' | ||
| ref: 'remove-attachments-rendering' |
Contributor
There was a problem hiding this comment.
This PR was flagged by the "Seal" notification, I'm not sure if it's still a work in progress (you may be planning to remove that anyway) but we don't want this change to be merged to main to keep our CI stable.
Suggested change
| ref: 'remove-attachments-rendering' | |
| ref: 'main' |
patrickpatrickpatrick
force-pushed
the
remove-documents-from-details
branch
from
faddf07 to
33e6ae3
Compare
ChrisBAshton
approved these changes
Apr 17, 2026
patrickpatrickpatrick
force-pushed
the
remove-documents-from-details
branch
3 times, most recently
from
2560b0a to
bab1fef
Compare
To reflect changes made in Whitehall to remove `documents` from `details` of publications.
patrickpatrickpatrick
force-pushed
the
remove-documents-from-details
branch
from
bab1fef to
a6bc4f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
details.documentsfrom mandatory fields ofpublicationdocumentsfromdetailsWhy
documentsis no longer consumed by frontend applications to render attachments, insteadattachmentswithindetailsis used. Therefore we can removedocumentsfrompublicationand update the examples to reflect this change. This is related to alphagov/whitehall#11366 which removesdocumentsfromdetailswithin Whitehall.This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.