Skip to content

chore: add ticket references to TODOs and enforce via CI#71

Merged
storopoli merged 5 commits intomainfrom
chore-add-todo-tickets
Apr 14, 2026
Merged

chore: add ticket references to TODOs and enforce via CI#71
storopoli merged 5 commits intomainfrom
chore-add-todo-tickets

Conversation

@prajwolrg
Copy link
Copy Markdown
Collaborator

@prajwolrg prajwolrg commented Apr 10, 2026

Description

Add a CI check and justfile task that ensures all TODO/FIXME/HACK comments include a ticket reference (e.g. TODO(STR-1234)). Existing ticketless TODOs are updated with their corresponding Jira tickets or removed where the work is already done.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency update
  • Security fix

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@prajwolrg prajwolrg self-assigned this Apr 10, 2026
@prajwolrg prajwolrg force-pushed the chore-add-todo-tickets branch 2 times, most recently from a830914 to a2213c2 Compare April 10, 2026 11:24
@prajwolrg prajwolrg marked this pull request as ready for review April 10, 2026 11:26
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

Commit: 55da9d9
SP1 Execution Results

program cycles success
ASM STF 118,476,744 yes
Moho Recursive 11,576,264 yes

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/subprotocols/admin/src/handler.rs 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
bin/asm-runner/src/prover/input.rs 99.30% <ø> (ø)
crates/common/src/msg.rs 86.04% <ø> (ø)
crates/common/src/subprotocol.rs 100.00% <ø> (ø)
crates/manifest-types/src/payloads.rs 71.42% <ø> (ø)
crates/stf/src/manager.rs 91.79% <ø> (ø)
crates/stf/src/stage.rs 100.00% <ø> (ø)
crates/stf/src/transition.rs 97.67% <ø> (ø)
crates/stf/src/tx_filter.rs 100.00% <ø> (ø)
crates/subprotocols/bridge-v1/src/handler.rs 93.82% <100.00%> (+0.07%) ⬆️
...tes/subprotocols/bridge-v1/src/state/assignment.rs 94.37% <ø> (ø)
... and 4 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@prajwolrg prajwolrg requested a review from storopoli April 11, 2026 14:01
Copy link
Copy Markdown
Collaborator

@evgenyzdanovich evgenyzdanovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@prajwolrg prajwolrg force-pushed the chore-add-todo-tickets branch from 6ce927f to 22ffd65 Compare April 13, 2026 13:52
Copy link
Copy Markdown
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 217f102

@storopoli storopoli enabled auto-merge April 14, 2026 09:19
@storopoli storopoli added this pull request to the merge queue Apr 14, 2026
Merged via the queue into main with commit 030639a Apr 14, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants