Skip to content

feat(admin): emit AsmStfUpdate log on ASM verifying key update#63

Open
prajwolrg wants to merge 2 commits intomainfrom
STR-1721-asm-vk-change-log
Open

feat(admin): emit AsmStfUpdate log on ASM verifying key update#63
prajwolrg wants to merge 2 commits intomainfrom
STR-1721-asm-vk-change-log

Conversation

@prajwolrg
Copy link
Copy Markdown
Collaborator

@prajwolrg prajwolrg commented Apr 7, 2026

Description

Implement AsmStfUpdate log emission when an ASM predicate update activates and add tests to verify it.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency update
  • Security fix

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@prajwolrg prajwolrg changed the title feat: asm vk change log feat(admin): emit AsmStfUpdate log on ASM verifying key update Apr 7, 2026
@prajwolrg prajwolrg force-pushed the STR-1721-asm-vk-change-log branch from a5f9793 to 9658ae7 Compare April 7, 2026 15:32
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
crates/subprotocols/admin/src/handler.rs 91.01% <100.00%> (-3.74%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Commit: ba284fe
SP1 Execution Results

program cycles success
ASM STF 118,483,762 yes
Moho Recursive 11,586,699 yes

@prajwolrg prajwolrg marked this pull request as ready for review April 8, 2026 01:47
@prajwolrg prajwolrg self-assigned this Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants