Skip to content

Feat/mipidsi async support#72

Draft
xgroleau wants to merge 6 commits intoalmindor:masterfrom
xgroleau:feat/mipidsi-async-support
Draft

Feat/mipidsi async support#72
xgroleau wants to merge 6 commits intoalmindor:masterfrom
xgroleau:feat/mipidsi-async-support

Conversation

@xgroleau
Copy link
Copy Markdown
Contributor

@xgroleau xgroleau commented Aug 21, 2023

Reimplemented using async as discussed in #63. Pretty much copy/paste with async/await keywords

Couples things to note and discussion points:

  • Async crate uses the alpha embedded-hal
  • Currently using the git version of display-interface, we might want to wait for the release
  • Some things where made public to allow reuse from the non async to async crate.
    • We could use a -common crate and put everything public and the crate but not reexport it in the main crates
  • Currently the doc is copy/pasted, we might want to modify some things or just reference the base library? (e.g. "Async version of [mipidsi::Display]") Whatever you think is best for the doc

@xgroleau xgroleau mentioned this pull request Sep 13, 2023
@KortanZ KortanZ mentioned this pull request May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant