chore: release airbyte/airbyte 1.9.2 with oidc fix#24
Open
Conall Ó Gribín (Conall-airbyte) wants to merge 1 commit intomainfrom
Open
chore: release airbyte/airbyte 1.9.2 with oidc fix#24Conall Ó Gribín (Conall-airbyte) wants to merge 1 commit intomainfrom
Conall Ó Gribín (Conall-airbyte) wants to merge 1 commit intomainfrom
Conversation
Conall Ó Gribín (Conall-airbyte)
requested a review
from Justin Pye (bernielomax)
Author
|
As our CI for v1 Charts seem to be gone at this point, I tested this locally, via a clean install and an upgrade from appVersion:1.8.5, ChartVersion:1.8.5 e.g 
and here we see the UI correct includes the Enterprise Auth login screen, including my configured Okta auth: |
Author
|
I don't think there's any good way to test this now other than merging it to master, correct me if i'm wrong Justin Pye (@bernielomax) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue (https://github.com/airbytehq/oncall/issues/10069) where, when we attempt to deploy appVersion 2.0.0, or later with the v1 charts, OIDC based auth doesn't work, and users are not able to login to airbyte.
who is affected?
anyone who has set:
identityProvider: type: oidcin their values.yaml
when they encounter this issue, , they would be see the simple auth login page post deployment, and all login attempts would fail.
This PR fixes this by making sure we include the appropriate env vars for appVersion 2.0.0+ to consume OIDC config properly when deploying airbyte with the V1 Charts.