chore(source-stripe): lower default num_workers from 25 to 10#74092
Draft
Alfredo Garcia (agarctfi) wants to merge 1 commit intomasterfrom
Draft
chore(source-stripe): lower default num_workers from 25 to 10#74092Alfredo Garcia (agarctfi) wants to merge 1 commit intomasterfrom
Alfredo Garcia (agarctfi) wants to merge 1 commit intomasterfrom
Conversation
Reduces the default concurrent worker count for production Stripe API keys from 25 to 10 to avoid rate limiting. Testing on a live connection showed that 25 and 20 workers consistently triggered rate limits, while 10 workers ran reliably without issues. Co-Authored-By: alfredo.garcia@airbyte.io <freddy.garcia7.fg@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Lowers the default
num_workers(concurrent workers) for the Stripe source connector from 25 to 10 for production API keys. The previous default of 25 was observed to consistently trigger Stripe API rate limiting on live connections.This was identified through a week-long monitoring exercise on a production connection: 25 and 20 workers both caused repeated sync failures due to rate limiting, while 10 workers synced reliably. Incremental testing from 10→14 workers all succeeded on incremental syncs, but since Stripe uses
StateDelegatingStream, the initial full-refresh sync is more concurrency-intensive and 10 was the first value that passed cleanly.How
Three locations in
manifest.yamlupdated to change the production default from 25 to 10:num_workers=1to2. Functionally unchanged since neither 25 nor 10 equals 1, but updated for consistency.num_workersis not explicitly configured. Test/sandbox keys still default to 4.Review guide
airbyte-integrations/connectors/source-stripe/manifest.yaml— all three changes are in close proximity (lines 1919–1954)default_concurrency) — this is the runtime behavior changedefault: 10) — UI/spec defaultKey questions for reviewer:
num_workersexplicitly set are unaffected; only connections relying on the default will see a change.User Impact
num_workers: No impact — their configured value is preserved.Can this PR be safely reverted and rolled back?
Link to Devin run: https://app.devin.ai/sessions/1194ea9a614a4ad992a36c89471eddd8
Requested by: Alfredo Garcia (@agarctfi)