feat(source-partnerstack): add missing fields to Transactions stream schema#74086
Conversation
…schema Add test, metadata, archived, and company fields to the Transactions stream schema to match the PartnerStack API response. Also fix product_key type from object to string. Co-Authored-By: lucas.leadbetter@airbyte.io <lucas.leadbetter@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Note 📝 PR Converted to Draft More info...Thank you for creating this PR. As a policy to protect our engineers' time, Airbyte requires all PRs to be created first in draft status. Your PR has been automatically converted to draft status in respect for this policy. As soon as your PR is ready for formal review, you can proceed to convert the PR to "ready for review" status by clicking the "Ready for review" button at the bottom of the PR page. To skip draft status in future PRs, please include |
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
Co-Authored-By: lucas.leadbetter@airbyte.io <lucas.leadbetter@gmail.com>
|
|
/ai-review
Reviewing PR for connector safety and quality.
|
|
🔍 AI PR Review in progress — evaluating gates for this PR. Report will follow shortly. Session: https://app.devin.ai/sessions/eb43ed9a906a48b99deea3f5020533ff |
AI PR Review ReportReview Action: REQUEST CHANGES
🔧 Remediation RequiredRequired ActionsCI Checks (FAIL):
Backwards Compatibility (UNKNOWN — requires human sign-off):
Live / E2E Tests (UNKNOWN):
📋 PR Details & EligibilityConnector & PR InfoConnector(s): Auto-Approve EligibilityEligible: No Review Action DetailsREQUEST CHANGES — The CI Checks gate has definitively FAILed (test check failed, not pending). The Backwards Compatibility gate requires human sign-off for the
🔍 Gate Evaluation DetailsGate-by-Gate Analysis
Detailed Trigger AnalysisBackwards Compatibility triggers:
CI Checks triggers:
📚 Evidence ConsultedEvidence
❓ How to RespondProviding Context or JustificationYou can add explanations that the bot will see on the next review: Option 1: PR Description (recommended) ## AI PR Review Justification
### {Gate Name}
[Your explanation here]Option 2: PR Comment After adding your response, re-run Note: Justifications provide context for the bot to evaluate. For some gates (like the Live / E2E Tests gate), a sufficient justification can lead to PASS. For other gates, justifications help explain the situation but may still require escalation if the gate cannot be remediated. |
![octavia-bot[bot]](https://avatars.githubusercontent.com/in/217399?s=60&v=4){kind=small}
Co-Authored-By: lucas.leadbetter@airbyte.io <lucas.leadbetter@gmail.com>
Co-Authored-By: lucas.leadbetter@airbyte.io <lucas.leadbetter@gmail.com>
|
Deploy preview for airbyte-docs ready! ✅ Preview Built with commit e73dc27. |
2 participants
What
The Transactions stream schema in
source-partnerstackis missing several fields that the PartnerStack API returns. This PR adds the missing fields.How
Updates the inline schema for the
transactionsstream inmanifest.yaml:test(boolean),metadata(object),archived(boolean),company(object)All changes are purely additive and were validated against the PartnerStack OpenAPI spec.
Version bumped to
0.3.12with changelog entry.Updates since last revision
product_keytype change (object→string) per reviewer feedback to avoid a potentially breaking change. The PR is now purely additive.Review guide
airbyte-integrations/connectors/source-partnerstack/manifest.yaml— schema additions in thetransactionsschema block (bottom of file)airbyte-integrations/connectors/source-partnerstack/metadata.yaml— version bump0.3.11→0.3.12docs/integrations/sources/partnerstack.md— changelog entryHuman review checklist
partnerstack.mdstill mentions "fix product_key type from object to string" but that change was reverted. The changelog text should be updated before merge.test,metadata,archived,company) match actual API responses — these were identified from the OpenAPI spec but not validated against a live PartnerStack account.User Impact
Users syncing the Transactions stream will now see
test,metadata,archived, andcompanyfields properly typed in their schema.Can this PR be safely reverted and rolled back?
Link to Devin run: https://app.devin.ai/sessions/195ce7694bdb4d83abaa8837af4599df
Requested by: Lucas Leadbetter (@lleadbet)