fix(ci): replace stale bulk CDK version check with per-package checks#74084
Draft
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Draft
fix(ci): replace stale bulk CDK version check with per-package checks#74084devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
The checkBuildNumber task checks the top-level version.properties (0.2.8), which is a legacy version from before the base/extract/load split. This causes CI failures for any PR that modifies extract, load, or base code without bumping the stale top-level version. Replace the single checkBuildNumber with per-package version checks (checkBaseVersion, checkExtractVersion, checkLoadVersion), each gated by path filters matching the corresponding publish workflows. Co-Authored-By: Yarden Carmeli <yarden.carmeli@airbyte.io>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
Note 📝 PR Converted to Draft More info...Thank you for creating this PR. As a policy to protect our engineers' time, Airbyte requires all PRs to be created first in draft status. Your PR has been automatically converted to draft status in respect for this policy. As soon as your PR is ready for formal review, you can proceed to convert the PR to "ready for review" status by clicking the "Ready for review" button at the bottom of the PR page. To skip draft status in future PRs, please include |
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
Bulk CDK version checkCI job has been broken for all PRs that modify extract, load, or base CDK code since the bulk CDK was split into independent packages. It runscheckBuildNumber, which checks the top-levelairbyte-cdk/bulk/version.properties(frozen at0.2.8— a legacy version from before the split). Since0.2.8already exists in Maven, the check always fails even when the correct per-package version has been bumped.This unblocks #74007 and all future PRs that modify bulk CDK package code.
How
Replaced the single broad path filter (
changes-in-bulk-artifact) and stalecheckBuildNumberGradle task with:base,extract,load) — patterns mirror the existing publish workflows (java-bulk-cdk-base-publish.yml,java-bulk-cdk-extract-publish.yml,java-bulk-cdk-load-publish.yml), scoped tosrc/mainandsrc/testFixtures.checkBaseVersion,checkExtractVersion, and/orcheckLoadVersiondepending on which packages were modified.The
run-check-bulk-cdk-versionjob ID andbulk-cdk-version-check-resultdownstream job are preserved to maintain compatibility.Review guide
.github/workflows/java-cdk-tests.yml— the only file changed.Key things to verify:
java-bulk-cdk-{base,extract,load}-publish.yml)airbyte-cdk/bulk/that don't fall into base, extract, or load?ifconditions correctly gate each version checkUser Impact
CDK developers will no longer see spurious
Bulk CDK version checkfailures on PRs that correctly bump the per-package version. The check now validates the right version file for the package being changed.Can this PR be safely reverted and rolled back?
Reverting restores the old (broken) behavior — the stale
checkBuildNumbercheck. No data loss or side effects.Devin session
Requested by: Yarden Carmeli (yarden.carmeli@airbyte.io)