Skip to content

chore(source-google-ads): use dev CDK with concurrency logging for debugging#74083

Draft
devin-ai-integration[bot] wants to merge 3 commits intomasterfrom
devin/1772185086-google-ads-dev-cdk-logging
Draft

chore(source-google-ads): use dev CDK with concurrency logging for debugging#74083
devin-ai-integration[bot] wants to merge 3 commits intomasterfrom
devin/1772185086-google-ads-dev-cdk-logging

Conversation

@devin-ai-integration
Copy link
Contributor

What

Temporary dev prerelease of source-google-ads that uses a CDK branch with added concurrency-level logging at startup. This is to diagnose a deterministic deadlock in Airbyte Cloud where the connector hangs when the num_workers config field is absent but works when explicitly set — despite both cases producing identical concurrency levels locally.

Related CDK PR: airbytehq/airbyte-python-cdk#925

⚠️ This PR is NOT intended to be merged. It exists solely to publish a connector prerelease for Cloud debugging.

How

  • Changed airbyte-cdk dependency from PyPI 7.9.2 to a git branch (devin/1772184954-log-concurrency-level) that adds an info-level log line in ConcurrentDeclarativeSource.__init__() reporting the resolved concurrency_level, initial_number_of_partitions_to_generate, and whether the concurrency level was defined in the manifest.
  • Updated poetry.lock accordingly.

Review guide

  1. pyproject.toml — single-line dependency change (line 23)
  2. poetry.lock — auto-generated; note the CDK resolves to version 0.0.0 because poetry-dynamic-versioning doesn't apply on non-tagged branch commits. Also note nltk, joblib, and tqdm were dropped as transitive deps — this reflects changes on CDK main since v7.9.2.

User Impact

No user impact — this is a debug prerelease that will only be deployed to an internal sandbox workspace to inspect concurrency configuration logs.

Can this PR be safely reverted and rolled back?

  • YES 💚

Requested by: Anatolii Yatsuk (@tolik0)

Link to Devin run: https://app.devin.ai/sessions/bf0f8e1a923541648f70ec31d962b9e9

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • 🛠️ Quick Fixes
    • /format-fix - Fixes most formatting issues.
    • /bump-version - Bumps connector versions, scraping changelog description from the PR title.
  • ❇️ AI Testing and Review (internal link: AI-SDLC Docs):
    • /ai-prove-fix - Runs prerelease readiness checks, including testing against customer connections.
    • /ai-canary-prerelease - Rolls out prerelease to 5-10 connections for canary testing.
    • /ai-review - AI-powered PR review for connector safety and quality gates.
  • 🚀 Connector Releases:
    • /publish-connectors-prerelease - Publishes pre-release connector builds (tagged as {version}-preview.{git-sha}) for all modified connectors in the PR.
    • /bump-progressive-rollout-version - Bumps connector version with an RC suffix (2.16.10-rc.1) for progressive rollouts (enableProgressiveRollout: true).
      • Example: /bump-progressive-rollout-version changelog="Add new feature for progressive rollout"
  • ☕️ JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
    • /bump-bulk-cdk-version bump=patch changelog='foo' - Bump the Bulk CDK's version. bump can be major/minor/patch.
  • 🐍 Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.
  • ⚙️ Admin commands:
    • /force-merge reason="<REASON>" - Force merges the PR using admin privileges, bypassing CI checks. Requires a reason.
      Example: /force-merge reason="CI is flaky, tests pass locally"
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@github-actions
Copy link
Contributor

Pre-release Connector Publish Started

Publishing pre-release build for connector source-google-ads.
PR: #74083

Pre-release versions will be tagged as {version}-preview.5f04e53
and are available for version pinning via the scoped_configuration API.

View workflow run

@tolik0
Copy link
Contributor

Anatolii Yatsuk (tolik0) commented Feb 27, 2026

/publish-connectors-prerelease

Pre-release Connector Publish Started

Publishing pre-release build for connector source-google-ads.
PR: #74083

Pre-release versions will be tagged as {version}-preview.5f04e53
and are available for version pinning via the scoped_configuration API.

View workflow run

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2026

source-google-ads Connector Test Results

262 tests   258 ✅  41m 46s ⏱️
  2 suites    4 💤
  2 files      0 ❌

Results for commit b2d6798.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2026

Pre-release Connector Publish Started

Publishing pre-release build for connector source-google-ads.
PR: #74083

Pre-release versions will be tagged as {version}-preview.6a49204
and are available for version pinning via the scoped_configuration API.

View workflow run
Pre-release Publish: SUCCESS

Docker image (pre-release):
airbyte/source-google-ads:4.1.6-preview.6a49204

Docker Hub: https://hub.docker.com/layers/airbyte/source-google-ads/4.1.6-preview.6a49204

Registry JSON:

…697606 with enhanced logging

Co-Authored-By: unknown <>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2026

Pre-release Connector Publish Started

Publishing pre-release build for connector source-google-ads.
PR: #74083

Pre-release versions will be tagged as {version}-preview.b2d6798
and are available for version pinning via the scoped_configuration API.

View workflow run
Pre-release Publish: SUCCESS

Docker image (pre-release):
airbyte/source-google-ads:4.1.6-preview.b2d6798

Docker Hub: https://hub.docker.com/layers/airbyte/source-google-ads/4.1.6-preview.b2d6798

Registry JSON:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants