fix(source-amazon-seller-partner): remove deprecated GET_V2_SETTLEMENT_REPORT_DATA_FLAT_FILE stream#74065
Draft
Danylo Jablonski (DanyloGL) wants to merge 2 commits intomasterfrom
Conversation
…T_REPORT_DATA_FLAT_FILE stream Remove the settlement report stream (GET_V2_SETTLEMENT_REPORT_DATA_FLAT_FILE) per Amazon SP-API deprecation. The report type is deprecated March 17, 2025 and will be removed March 25, 2026. See: https://developer-docs.amazon.com/sp-api/docs/sp-api-deprecations Resolves: airbytehq/oncall#10367 Co-Authored-By: Danylo Jablonski <daniel.i.jablonski@globallogic.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
Contributor
|
…n after settlement report removal Co-Authored-By: Danylo Jablonski <daniel.i.jablonski@globallogic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
GET_V2_SETTLEMENT_REPORT_DATA_FLAT_FILEstream from the Amazon Seller Partner source connector ahead of its Amazon SP-API removal date of March 25, 2026.Amazon deprecated this report type on March 17, 2025 and will permanently remove it on March 25, 2026. See: SP-API Deprecation Schedule
Resolves: https://github.com/airbytehq/oncall/issues/10367 (settlement reports portion)
How
Pure deletion — removes all references to the settlement report stream:
manifest.yaml: Removed stream definition (get_v2_settlement_report_data_flat_file), its parent helper stream (flat_file_settlement_v2_helper), the enum entry in the spec, the$refin the streams list, and the inline schema (~329 lines removed)components.py: RemovedFlatFileSettlementV2ReportsTypeTransformerclassunit_tests/test_transform_function.py: Removed associated test and importunit_tests/test_source.py: Updatedtest_streams_countassertion from 52 → 51metadata.yaml: Version bump 5.4.1 → 6.0.0 withbreakingChangesentry scoped to this stream, upgrade deadline set to 2026-03-25acceptance-test-config.yml,configured_catalog_incremental.json, andfuture_state.jsonFollows the same pattern as the v5.0.0 FBA SNS removal.
Review guide
metadata.yaml— Verify the breaking change entry and upgrade deadline are correctmanifest.yaml— Confirm no dangling references remain tosettlementorflat_file_settlement_v2_helpercomponents.py— ConfirmFlatFileSettlementV2ReportsTypeTransformeris not referenced by any other streamerd/source.dbml,erd/discovered_catalog.json,erd/estimated_relationships.json) still reference this stream — these are auto-generated and expected to be regenerated separatelyUser Impact
GET_V2_SETTLEMENT_REPORT_DATA_FLAT_FILEstream will see it removed after upgrading to v6.0.0Can this PR be safely reverted and rolled back?
Link to Devin run: https://app.devin.ai/sessions/198956df19494e578b837c4fe81746aa
Requested by: Danylo Jablonski (@DanyloGL)