source-postgres: field type mapping#65983
source-postgres: field type mapping#65983Matt Bayley (mwbayley) merged 3 commits intosource-postgres/bulk-cdkfrom
Conversation
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
|
|
|
|
|
|
|
Matt Bayley (mwbayley)
force-pushed
the
mbayley/source-postgres/field-type-tests
branch
from
40cf841 to
de8cc06
Compare
| } | ||
| } | ||
|
|
||
| class InfJsonEncoder<T>(private val base: JsonEncoder<T>) : JsonEncoder<InfWrapper<T>> { |
There was a problem hiding this comment.
Since we're using the type of JsonEncoder as a hint for protobuf encoding, this may create a difficulty because the inner type is erased.
Maybe reified can help here.
I'm noting this as a difficulty to myself.
There was a problem hiding this comment.
inline and reified are new to me. Good idea.
There was a problem hiding this comment.
I just played around with this a bit. Maybe we can pair on it in person later this week.
| JDBCType.CHAR, | ||
| JDBCType.VARCHAR, | ||
| // JDBCType.TINYTEXT, | ||
| // JDBCType.TEXT, |
There was a problem hiding this comment.
all these don't exist?
There was a problem hiding this comment.
Yes, forgot to clean this up. Commit incoming.
There was a problem hiding this comment.
wait, I have this removed locally and the sha on the tip commit matches.... something weird is going on
There was a problem hiding this comment.
Oh, the commented ones are all in red here.... duh. Yes, these JDBC types are not present in column metadata for Postgres.
| object PostgresSource { | ||
| @JvmStatic | ||
| fun main(args: Array<String>) { | ||
| // TODO: Remove before merging |
There was a problem hiding this comment.
oh 🤦
Matt Bayley (mwbayley)
merged this pull request
into
source-postgres/bulk-cdk
Matt Bayley (mwbayley)
deleted the
mbayley/source-postgres/field-type-tests
branch
Co-authored-by: Rodi Reich Zilberman <867491+rodireich@users.noreply.github.com>
3 participants
Add field type mapping and associated tests based on the testing framework to the postgres source on the bulk CDK.
Can this PR be safely reverted and rolled back?