[source-mysql] More meaningful errors for variables used in extra checks for CDC#55731
Merged
Marcos Marx (marcosmarxm) merged 3 commits intoairbytehq:masterfrom Mar 14, 2025
Merged
Conversation
|
Przemysław Dąbek (@szemek) is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
changed the title
Yue Li (theyueli)
requested review from
Matt Bayley (mwbayley) and
Yarden Carmeli (yardencarmeli)
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
force-pushed
the
source-mysql-errors
branch
from
5845dbb to
daacd97
Compare
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Contributor
Marcos Marx (marcosmarxm)
left a comment
Marcos Marx (marcosmarxm)
left a comment
There was a problem hiding this comment.
Thanks for this QOL. Yue Li (@theyueli) can we add this to the team sprint to review?
Yue Li (theyueli)
approved these changes
Mar 13, 2025
Contributor
Yue Li (theyueli)
left a comment
Yue Li (theyueli)
left a comment
There was a problem hiding this comment.
thanks for this enhancement!
github-project-automation
bot
moved this from Backlog
to Ready to Ship
in 🧑🏭 Community Pull Requests
Contributor
|
Marcos Marx (@marcosmarxm) looks good to me, please help ensure CI and checks run well, and we resolve the conflict by bumping up to the correct version. Thanks! |
Marcos Marx (marcosmarxm)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Marcos Marx (marcosmarxm)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Marcos Marx (marcosmarxm)
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
Marcos Marx (marcosmarxm)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Marcos Marx (marcosmarxm)
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
Marcos Marx (marcosmarxm)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Marcos Marx (marcosmarxm)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Contributor
Author
|
I reverted one commit to make SpotBugs happy. It didn't like interpolated strings in SQL queries and I completely understand that. |
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
force-pushed
the
source-mysql-errors
branch
from
b778fd9 to
0ba4f12
Compare
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Przemysław Dąbek (szemek)
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
github-project-automation
bot
moved this from Ready to Ship
to Done
in 🧑🏭 Community Pull Requests
Sven Pöche (Valgard)
pushed a commit
to mayflower/airbyte
that referenced
this pull request
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
More meaningful errors for source-mysql connector.
Motivation:
https://airbytehq.slack.com/archives/C021JANJ6TY/p1741784591500319
Instead of
it's way better to provide the name of variable
How
Passing variable name to an exception.
Review guide
airbyte-integrations/connectors/source-mysql/src/main/kotlin/io/airbyte/integrations/source/mysql/MySqlSourceMetadataQuerier.ktUser Impact
Improvement for connector users.
Can this PR be safely reverted and rolled back?