feat: Add regex_replace Jinja filter for low-code connector builder#904
Conversation
Co-Authored-By: lucas.leadbetter@airbyte.io <lucas.leadbetter@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1770835380-add-regex-replace-filter#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1770835380-add-regex-replace-filterPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
📝 WalkthroughWalkthroughA new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Adds a
regex_replaceJinja filter to the low-code connector builder's interpolation system, complementing the existingregex_searchfilter. This wraps Python'sre.sub()and enables regex-based string replacement in declarative manifests:Closes #902
Review & Testing Checklist for Human
regex_search— both will raisere.erroron bad patterns). Decide if that's acceptable or if a try/except should be added.ManifestDeclarativeSource) rather than only at the interpolation level.Notes
Summary by CodeRabbit
Release Notes
New Features
Tests