Merged
Conversation
… Sentry Introduce UntrackedError for errors caused by the user's environment (permissions, disk space, docker not running, etc.) that should be displayed to the user but not sent to error tracking since they are outside abctl's control. This is distinct from abctl.Error which provides user-friendly help messages for specific errors. UntrackedError is specifically about whether an error should be reported to Sentry, not about displaying help text. Addresses Sentry issues ABCTL-A and ABCTL-37 which account for over 20,000 events combined from user environment issues (missing files, permission denied errors) that are not actionable bugs.
Wrap the following errors to exclude them from Sentry: - ErrDocker: docker not running or inaccessible - ErrPort: port already in use - ErrAirbyteDir: airbyte directory inaccessible - ErrIpAddressForHostFlag: invalid host flag (IP address) - ErrInvalidHostFlag: invalid host flag format - cannot read PG_VERSION file (excluding not found)
Justin Pye (bernielomax)
changed the title
Ryan Br... (tryangul)
left a comment
Ryan Br... (tryangul)
left a comment
There was a problem hiding this comment.
Is it worth cranking out a few tests for this behavior?
Contributor
Author
|
The error handler is not written in a way that is easy to test. I started to add some around the new type, but in the end, I was just testing Go's standard lib. |
Contributor
There was a problem hiding this comment.
✅ I'll stop short of official approval, since I don't know this codebase. But it looks good for my part. Thanks, Justin Pye (@bernielomax) !
Francis Genet (frifriSF59)
approved these changes
Jan 21, 2026
Justin Pye (bernielomax)
deleted the
bernielomax/feat/untracked-errors
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UntrackedErrortype for errors outside abctl's control (permissions, docker not running, port in use, etc.)abctl.Errorwhich is for help messagesMotivation
Addresses Sentry issues ABCTL-A and ABCTL-37 which account for over 20,000 events from user environment issues that are not actionable bugs.
Changes
UntrackedErrortype with proper error wrappinghandleErrto skip Sentry for UntrackedErrorErrDocker,ErrPort,1ErrAirbyteDir,ErrIpAddressForHostFlag,ErrInvalidHostFlag, PG_VERSION read errorsNote
Existing users won't benefit until they upgrade. Consider adding Sentry inbound filters for immediate relief:
*permission denied*PG_VERSION**no such file or directory*values.yaml*