Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the built-in FTL stub generator implementation in favor of the external ftl-extract package, which provides better functionality using Python's ast library.
Key Changes
- Completely removes the
FluentVisitorimplementation that parsed Fluent translation files - Replaces
from_files_to_file_exfunctionality with a deprecation message directing users toftl-extract - Updates deprecation messages in CLI commands to include usage examples
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| aiogram_i18n/utils/fluent_stub/visitor.py | Deleted entire FluentVisitor class that handled Fluent file parsing |
| aiogram_i18n/utils/fluent_stub/init.py | Replaced stub generation logic with deprecation notice pointing to ftl-extract |
| aiogram_i18n/utils/cli/multiple_extract.py | Enhanced deprecation message with ftl-extract usage example |
| aiogram_i18n/utils/cli/extract.py | Enhanced deprecation message with ftl-extract usage example |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop FTL stub generator due to having better FTL-Extract
ftl stub, that uses pythonastlib to generate stubs