Skip to content

Drop FTL stub generator#49

Merged
andrew000 merged 1 commit intodevfrom
drop-ftl-stub-gen
Oct 22, 2025
Merged

Drop FTL stub generator#49
andrew000 merged 1 commit intodevfrom
drop-ftl-stub-gen

Conversation

@andrew000
Copy link
Copy Markdown
Contributor

Drop FTL stub generator due to having better FTL-Extract ftl stub, that uses python ast lib to generate stubs

@andrew000 andrew000 self-assigned this Oct 22, 2025
@andrew000 andrew000 requested a review from Copilot October 22, 2025 23:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the built-in FTL stub generator implementation in favor of the external ftl-extract package, which provides better functionality using Python's ast library.

Key Changes

  • Completely removes the FluentVisitor implementation that parsed Fluent translation files
  • Replaces from_files_to_file_ex functionality with a deprecation message directing users to ftl-extract
  • Updates deprecation messages in CLI commands to include usage examples

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
aiogram_i18n/utils/fluent_stub/visitor.py Deleted entire FluentVisitor class that handled Fluent file parsing
aiogram_i18n/utils/fluent_stub/init.py Replaced stub generation logic with deprecation notice pointing to ftl-extract
aiogram_i18n/utils/cli/multiple_extract.py Enhanced deprecation message with ftl-extract usage example
aiogram_i18n/utils/cli/extract.py Enhanced deprecation message with ftl-extract usage example

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@andrew000 andrew000 merged commit d55e937 into dev Oct 22, 2025
12 checks passed
@andrew000 andrew000 deleted the drop-ftl-stub-gen branch October 22, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants