Open
Conversation
constants gets passed to the JVM which is then ignored. This then causes any query that uses constants to fail with an 'Unknown variable' error
Fix three bugs in test_view_with_constants: use "path" instead of "value" for the column key, use FHIRPath %constant syntax instead of $constant, and use the named ResultRow factory for consistency. Also fix PEP 8 style issues and add a matching R test.
Secrets are not available for PRs from external contributors, causing the sonar step to fail. Split the install and SonarCloud steps so the analysis is skipped when SONAR_TOKEN is absent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.