Conversation
…te_signal tool The activate_signal tool in the training agent accepted signal_id (wrong field name) and destination/singular (wrong shape) as SDK-compat shims, masking the exact bug reported in #3349 instead of surfacing it. All three compliance storyboard YAMLs (signals_baseline, signal-owned, signal-marketplace) already use the correct fields. This aligns the training agent implementation with those storyboards. Also clarifies signal_agent_segment_id descriptions in both activate-signal-request.json and get-signals-response.json to make the distinction from signal_id (catalog object) explicit at the schema level. Refs #3349 — adcp-client scenario fix tracked separately. https://claude.ai/code/session_011S9bnPFjuLTCyPPEUD2AoD
…ix required Per pre-PR code review: idempotency_key was missing from the inputSchema properties and required was incorrectly empty, misrepresenting what the dispatcher enforces at runtime. https://claude.ai/code/session_011S9bnPFjuLTCyPPEUD2AoD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3349 — the
adcp-clientscenario fix (scenarios/signals.js) must be addressed in that repo separately.Summary
signal_id(wrong field),destination(singular), andoptionsSDK-compat aliases from the training agent'sactivate_signaltool definition; these shims were silently accepting the exact malformed payload reported in Storyboard 5.13 activate_signal scenario uses wrong field name and wrong type for signal identifier #3349 instead of surfacing it as an error.idempotency_keyto the tool inputSchema properties and updatesrequiredto['signal_agent_segment_id', 'destinations', 'idempotency_key'], matching both the wire schema (activate-signal-request.json) and the runtime dispatcher enforcement.signal_agent_segment_iddescription inactivate-signal-request.jsonandget-signals-response.jsonto make the distinction from thesignal_idcatalog object explicit at the schema level.All three compliance storyboard YAMLs (
signals_baseline,signal-owned,signal-marketplace) already use the correct fields — this aligns the training agent implementation with those storyboards.Non-breaking justification: removes non-spec aliases from a training agent tool definition; no wire-format or schema type changes. The compliance storyboard source YAMLs and the published
activate-signal-request.jsonrequired fields are unchanged. Callers sending correct protocol fields are unaffected.Routing note: this is a
patchchangeset. No3.0.xbranch exists — targetingmain. Needs @bokelley to cut a patch branch or merge into the upcoming 3.0.1 milestone once the branch is open.Pre-PR review
idempotency_keyin schema, emptyrequiredarray); no remaining blockerssignal_id/signal_agent_segment_iddistinction is a deliberate two-concept design (catalog ref vs. opaque activation handle); storyboard YAMLs already correctSession: https://claude.ai/code/session_011S9bnPFjuLTCyPPEUD2AoD
Generated by Claude Code