fix(server): raise storyboard eval/step rate limits for member dev iteration#3279
Draft
fix(server): raise storyboard eval/step rate limits for member dev iteration#3279
Conversation
…eration (#3277) Bumps storyboard eval cap from 5→10/hr and step cap from 30→60/hr so members can complete a typical 4-5 cycle debug session without hitting the wall. Admin bypass (skipForAdmins) is unchanged. Also fixes both 429 handlers to use the real Retry-After window position instead of a hardcoded Math.ceil(60*60) — matching the existing pattern used by agentReadRateLimiter in the same file. https://claude.ai/code/session_01SPJGvJCxD961HSCvtwyj3D
Contributor
Author
|
claude-triaged Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3277
Storyboard eval rate limits were too tight for member developer iteration: 5 evals/hr = roughly 2 debug cycles before hitting the wall on a single agent. This PR implements Option B from the issue (the author's recommendation): raise the caps to match a realistic iteration cadence.
Changes:
storyboardEvalRateLimiter: max 5 → 10/hrstoryboardStepRateLimiter: max 30 → 60/hrretryAfterto use the real window-position value from theRetry-Afterheader viaparseRetryAfterSeconds(was hardcodedMath.ceil(60 * 60)= always 3600s regardless of elapsed time). Pattern matchesagentReadRateLimiterin the same file.Non-breaking justification: server-side config change only; no protocol schema, task definition, or API contract changes. Admin bypass (
skipForAdmins) andskipFailedRequests: truebehavior unchanged.Option A (per-agent keying) deferred: the issue author recommends "only do A if non-admin reports keep coming." Option A also has an open design question (multiply-vs-fixed ceiling) and the correct key source is
req.params.encodedUrlnotreq.body.agent_url— needs owner input before implementation.Pre-PR review:
standardHeaders: truesets theRetry-Afterheader before the handler fires sores.getHeader('Retry-After')is always available; window-transition behavior (users at 5/5 before deploy get 5 more in-place) is intentionalSession: https://claude.ai/code/session_01SPJGvJCxD961HSCvtwyj3D
Generated by Claude Code