chore: Add DeleteUserProfile(s) method#79
Open
ohalushchak-exadel wants to merge 2 commits intomainfrom
Open
Conversation
Adds DeleteUserProfile and DeleteUserProfiles to Engine as counterparts to the existing setters, enabling callers to remove user segment profiles from the store. To support this, Del and MDel are added to the Store interface with corresponding implementations in MockStore and valkeystore.Store. The Valkey/Redis implementation uses a single DEL call for both the single and batch cases, since the command natively accepts multiple keys.
ohalushchak-exadel
requested review from
BaiyuScope3,
EmmaLouise2018,
bokelley and
subtle-supernova
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds DeleteUserProfile and DeleteUserProfiles to Engine as counterparts to the existing setters, enabling callers to remove user segment profiles from the store.
To support this, Del and MDel are added to the Store interface with corresponding implementations in MockStore and valkeystore.Store. The Valkey/Redis implementation uses a single DEL call for both the single and batch cases, since the command natively accepts multiple keys.