fix(examples): seed_product defaults, TERMS_REJECTED, targeting_overlay round-trip by bokelley · Pull Request #320 · adcontextprotocol/adcp-client-python

bokelley · 2026-04-30T13:53:49Z

Closes #319

Fixes the 5 storyboard failures blocking promotion of the storyboard CI job from continue-on-error: true to required (36/47 → 47/47 expected).

What changed

DemoStore.seed_product (examples/seller_agent.py) — Add setdefault for all 8 schema-required product fields (name, description, delivery_type, publisher_properties, format_ids, pricing_options, reporting_capabilities, delivery_measurement). A minimal fixture sent by the runner with only product_id now produces a fully-valid product entry. date_range_support default corrected from "none" (invalid) to "date_range" (schema default). Fixes failures 1 & 2.

DemoSeller.create_media_buy — Per-package measurement_terms.viewability_threshold > 80 now returns TERMS_REJECTED with recovery="correctable" (negotiation error, not terminal). viewability_threshold is a storyboard demo convention via additionalProperties; real sellers should apply their own criteria. Fixes failure 3.

DemoSeller.create_media_buy — Package construction now persists targeting_overlay, creative_assignments, and creatives into the stored package dict so get_media_buys can round-trip property_list.list_id. Fixes failure 4.

DemoSeller.update_media_buy — Builds a package_id → dict index (references into mb["packages"]) so targeting_overlay, creative_assignments, and creatives deltas are applied directly to the stored dict and visible on the next get_media_buys call. Fixes failure 5.

What was tested

pytest tests/test_seller_agent_storyboard.py — 8 new tests, all pass. Covers: seed_product defaults, fixture field preservation, TERMS_REJECTED (above threshold, at boundary, below threshold + recovery assertion), targeting_overlay create round-trip, targeting_overlay update round-trip.
pytest tests/ — 2352 passed, 22 skipped, 1 xfailed. The single failure (test_real_tls_handshake_still_validates_hostname) is a pre-existing network-dependent test unrelated to this change.
ruff check src/ tests/test_seller_agent_storyboard.py — clean.

Pre-PR review

Two expert passes ran on the final diff before this PR was opened.

code-reviewer: approved — noted missing description default (fixed) and boundary test (added); no blockers remain.
dx-expert: approved — noted measurement_terms is per-package not top-level (fixed), recovery="correctable" required (fixed), date_range_support: "none" invalid (fixed); no blockers remain.

Nit surfaced (not fixed in this PR): TERMS_REJECTED is absent from STANDARD_ERROR_CODES in helpers.py, so any other call site that uses it will default to recovery: "terminal". Tracking separately.

Triage-managed PR. This bot does not currently iterate on
review comments or PR conversation threads (only on the source
issue). To unblock:

Push fixup commits directly: gh pr checkout <num> →
fix → push.

Or re-trigger: comment /triage execute on the source
issue.

See adcp#3121
for context.

Session: https://claude.ai/code/session_01ENPdJ8Nk7YvUhfRpMXLa8w

Generated by Claude Code

…ay round-trip Fixes the 5 storyboard failures blocking storyboard CI promotion (issue #319): 1. DemoStore.seed_product — add setdefault calls for the six schema-required product fields (name, delivery_type, publisher_properties, format_ids, pricing_options, reporting_capabilities, delivery_measurement). A minimal fixture sent by the runner now produces a fully-valid product entry. 2. DemoSeller.create_media_buy — inspect measurement_terms.viewability_threshold and return TERMS_REJECTED when it exceeds 80, satisfying the create_media_buy_aggressive_terms storyboard step. 3. DemoSeller.create_media_buy — persist targeting_overlay, creative_assignments, and creatives on the stored package object so get_media_buys can round-trip property_list / list_id values (acme_outdoor_allowlist_v1 step). 4. DemoSeller.update_media_buy — apply targeting_overlay, creative_assignments, and creatives deltas to the persisted package state so the get_after_update step can read back the updated property_list (acme_outdoor_no_match_v1 step). Adds 7 unit tests in tests/test_seller_agent_storyboard.py covering all fixed scenarios. Full suite: 2351 passed, 22 skipped, 1 xfailed; the single failure (test_real_tls_handshake_still_validates_hostname) is a pre-existing network-dependent test unrelated to this change. Refs #319 https://claude.ai/code/session_01ENPdJ8Nk7YvUhfRpMXLa8w

bokelley · 2026-04-30T14:08:43Z

Superseded by PR #321 — that branch includes this commit (cherry-picked) plus three additional fixes for the remaining storyboard CI failures (publisher_properties minItems: 1, format_ids[].agent_url normalization, available_reporting_frequencies minItems: 1). Closing this in favor of #321 unless there's a reason to keep both open.

bokelley · 2026-04-30T14:09:35Z

Acknowledged — deferring to #321. No objection to closing this one.

Generated by Claude Code

bokelley · 2026-04-30T14:10:46Z

Understood — noted the defer to #321. No action needed here from me; this PR can be closed whenever ready.

Generated by Claude Code

bokelley · 2026-04-30T14:11:28Z

Acknowledged — closing this PR since the work is deferred to #321.

Generated by Claude Code

bokelley · 2026-04-30T14:12:27Z

Acknowledged — no further action from triage on this PR. Work tracking lives in #321.

_Generated by Claude Code

Generated by Claude Code

bokelley · 2026-04-30T14:57:17Z

Superseded by #322 — same issue (#319) closed by the user-driven PR with verified end-to-end pass on storyboard.

bokelley · 2026-04-30T14:58:16Z

Acknowledged — this PR is superseded by #322 which closes #319 with a verified end-to-end storyboard pass. No further action needed here.

Generated by Claude Code

…normalization (#319) Closes #319. Storyboard CI on examples/seller_agent.py was failing with persistent schema-validation errors against products seeded by the storyboard runner. The seller's `seed_product` controller blindly appended fixture-shaped skeletons to the PRODUCTS list without filling schema-required defaults; subsequent `get_products` responses then failed AdCP 3.0.1 validation. Fixes: * `publisher_properties` defaulted to `[]` (violates schema's `minItems: 1`) — now defaults to `[{"publisher_domain": "example.com", "selection_type": "all"}]`. * `format_ids[].agent_url` was missing on caller-supplied fixtures shaped as `[{"id": "..."}]` — now normalized to fill in the local `AGENT_URL` when absent; existing values preserved. * `reporting_capabilities.available_reporting_frequencies` defaulted to `[]` (violates `minItems: 1`) — now defaults to `["hourly", "daily"]` matching the static PRODUCTS template. * TERMS_REJECTED gate narrowed: per-package measurement_terms inspection accepts seller-vendor terms (own domain, "internal" indicator) and tightens rejection criteria so only buyer-imposed unworkable terms trip the rejection path. * Persists round-trip fields (`targeting_overlay`, `creative_assignments`, `creatives`, `measurement_terms`, `budget`) through `create_media_buy` / `update_media_buy` so storyboard scenarios can verify state transitions. * Wires context echo on adcp_error responses. Tests: * `test_seed_product_minimal_fixture_satisfies_schema_requirements` — asserts the minimal-fixture path produces a product satisfying every `minItems: 1` constraint and `format_ids[].agent_url`. * `test_seed_product_normalizes_format_ids_missing_agent_url` — asserts the fill-when-missing AND preserve-when-present semantics for caller-supplied `format_ids`. * All 10 storyboard tests pass: tests/test_seller_agent_storyboard.py * Full suite: 2398 passed. Supersedes #320. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…normalization (#319) (#321) Closes #319. Storyboard CI on examples/seller_agent.py was failing with persistent schema-validation errors against products seeded by the storyboard runner. The seller's `seed_product` controller blindly appended fixture-shaped skeletons to the PRODUCTS list without filling schema-required defaults; subsequent `get_products` responses then failed AdCP 3.0.1 validation. Fixes: * `publisher_properties` defaulted to `[]` (violates schema's `minItems: 1`) — now defaults to `[{"publisher_domain": "example.com", "selection_type": "all"}]`. * `format_ids[].agent_url` was missing on caller-supplied fixtures shaped as `[{"id": "..."}]` — now normalized to fill in the local `AGENT_URL` when absent; existing values preserved. * `reporting_capabilities.available_reporting_frequencies` defaulted to `[]` (violates `minItems: 1`) — now defaults to `["hourly", "daily"]` matching the static PRODUCTS template. * TERMS_REJECTED gate narrowed: per-package measurement_terms inspection accepts seller-vendor terms (own domain, "internal" indicator) and tightens rejection criteria so only buyer-imposed unworkable terms trip the rejection path. * Persists round-trip fields (`targeting_overlay`, `creative_assignments`, `creatives`, `measurement_terms`, `budget`) through `create_media_buy` / `update_media_buy` so storyboard scenarios can verify state transitions. * Wires context echo on adcp_error responses. Tests: * `test_seed_product_minimal_fixture_satisfies_schema_requirements` — asserts the minimal-fixture path produces a product satisfying every `minItems: 1` constraint and `format_ids[].agent_url`. * `test_seed_product_normalizes_format_ids_missing_agent_url` — asserts the fill-when-missing AND preserve-when-present semantics for caller-supplied `format_ids`. * All 10 storyboard tests pass: tests/test_seller_agent_storyboard.py * Full suite: 2398 passed. Supersedes #320. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

bokelley added the claude-triaged label Apr 30, 2026

This was referenced Apr 30, 2026

storyboard: 5 fixture-dependent failures (default product fixtures + measurement_terms + targeting_overlay persistence) #319

Closed

fix(examples): seed_product complete defaults + format_ids agent_url normalization #321

Merged

bokelley closed this Apr 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(examples): seed_product defaults, TERMS_REJECTED, targeting_overlay round-trip#320

fix(examples): seed_product defaults, TERMS_REJECTED, targeting_overlay round-trip#320
bokelley wants to merge 1 commit intomainfrom
claude/issue-319-storyboard-fixture-gaps

bokelley commented Apr 30, 2026

Uh oh!

bokelley commented Apr 30, 2026

Uh oh!

bokelley commented Apr 30, 2026

Uh oh!

bokelley commented Apr 30, 2026

Uh oh!

bokelley commented Apr 30, 2026

Uh oh!

bokelley commented Apr 30, 2026

Uh oh!

bokelley commented Apr 30, 2026

Uh oh!

bokelley commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

bokelley commented Apr 30, 2026

What changed

What was tested

Pre-PR review

Uh oh!

bokelley commented Apr 30, 2026

Uh oh!

bokelley commented Apr 30, 2026

Uh oh!

bokelley commented Apr 30, 2026

Uh oh!

bokelley commented Apr 30, 2026

Uh oh!

bokelley commented Apr 30, 2026

Uh oh!

bokelley commented Apr 30, 2026

Uh oh!

bokelley commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants