Skip to content

feat(agents): triage PR ergonomics — refs adcp#3121#279

Merged
bokelley merged 1 commit intomainfrom
bokelley/triage-pr-ergonomics
Apr 25, 2026
Merged

feat(agents): triage PR ergonomics — refs adcp#3121#279
bokelley merged 1 commit intomainfrom
bokelley/triage-pr-ergonomics

Conversation

@bokelley
Copy link
Copy Markdown
Contributor

@bokelley bokelley commented Apr 25, 2026

Mirrors the changes from adcontextprotocol/adcp#3172 — three coordinated edits to .agents/routines/triage-prompt.md from issue adcp#3121.

What changes

1. Pre-PR build + test gate. Adds explicit "do not declare 'approved' in the pre-PR review block while build is red" rule, per adcp#3121 evidence that the bot's "approved" verdict next to red CI was a trust-eroding signal across 5+ recent PRs.

2. PR body now carries a "Triage-managed PR" block documenting the no-iteration policy:

> **Triage-managed PR.** This bot does not currently iterate on review
> comments or PR conversation threads (only on the source issue).
> To unblock:
>
> - **Push fixup commits directly:** `gh pr checkout <num>` → fix → push.
> - **Or re-trigger:** comment `/triage execute` on the source issue.
>
> See [adcp#3121](https://github.com/adcontextprotocol/adcp/issues/3121) for context.

Reviewers no longer have to guess whether to wait, push, or send back manually.

3. claude-triaged label applied to the PR after gh pr create (mirrors the issue label):

gh pr edit <PR#> --repo <owner>/<repo> --add-label claude-triaged

Makes triage-managed PRs searchable in PR list views, complements the claude/issue-NNNN-* branch pattern as a PR-ownership signal.

Repo-specific

This repo's pre-PR build commands stay as documented in PR constraints (no command change here, just the "don't approve while red" rule and the PR-body / label additions). adcp's PR uses npm run build && npm run typecheck since adcp's build chains the storyboard / compliance lint surface that motivated the original ask.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

Mirrors adcontextprotocol/adcp#3172. Three coordinated edits to
.agents/routines/triage-prompt.md:

1. Pre-PR gate: do not declare "approved" while build is red.
2. PR body now carries a "Triage-managed PR" block documenting
   the no-iteration policy (push fixup commits or re-trigger via
   /triage on the source issue).
3. claude-triaged label applied to PR after gh pr create
   (mirrors issue label, searchable from PR list views).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@bokelley bokelley merged commit 31606eb into main Apr 25, 2026
11 checks passed
@bokelley bokelley deleted the bokelley/triage-pr-ergonomics branch April 25, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant