fix(a2a): Checkpoint export + TaskState enum cleanup, pin release as 4.0.1#260
Closed
fix(a2a): Checkpoint export + TaskState enum cleanup, pin release as 4.0.1#260
Conversation
…te enum - Export ``Checkpoint`` TypedDict from the top-level ``adcp`` package so callers can ``from adcp import Checkpoint`` instead of reaching into ``adcp.client`` for the persistence-key type. - Compare ``task.status.state`` against ``TaskState.completed`` / ``TaskState.failed`` in ``_process_task_response`` to match the enum-based membership check in ``_NONTERMINAL_TASK_STATES`` — an upstream rename in a2a-sdk now fails as a type error instead of a silent classification drift. Also flips the in-progress release-please PR from 5.0.0 to 4.0.1. The prior commit (#258) landed breaking-style changes (``pending_task_id`` → ``active_task_id``, ``ValueError`` → ``TypeError`` on non-A2A) but 4.0.0 shipped under 48h earlier with no known A2A adopters — the salesagent migration is on MCP, and A2A adoption is deferred behind pluggable TaskStore / push-notification work. Treating those as pre-adoption corrections rather than a major bump. Release-As: 4.0.1 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
d8eab37 to
5c4413b
Compare
Contributor
Author
|
Folding into the consolidated 4.1.0 a2a-sdk 1.0 migration PR. Both changes (Checkpoint top-level export, TaskState enum comparisons in _process_task_response) will land there. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small follow-ups to PR #258, plus a `Release-As: 4.0.1` footer to override the pending 5.0.0 release PR (#257).
Code changes
Release positioning: 4.0.1 not 5.0.0
PR #258 landed with `feat(a2a)!:` + `BREAKING CHANGE:` footer, so release-please opened #257 for 5.0.0. The breaking bits were:
4.0.0 shipped <48h before #258 landed. Per the salesagent roadmap, MCP is the critical path; A2A adoption is deferred behind pluggable TaskStore / push-notification work that isn't merged yet. Treating these as pre-adoption corrections rather than a major bump.
What happens after merge
Once this lands on main, release-please will regenerate #257 at 4.0.1 instead of 5.0.0. Merge that and PyPI publishes 4.0.1.
Test plan
Heads-up, not blocking 4.0.1
🤖 Generated with Claude Code