Skip to content

#5 average#17

Open
RibhavKhanna wants to merge 2 commits intoZircoz:mainfrom
RibhavKhanna:average
Open

#5 average#17
RibhavKhanna wants to merge 2 commits intoZircoz:mainfrom
RibhavKhanna:average

Conversation

@RibhavKhanna
Copy link
Copy Markdown

#5 @Zircoz @haspdecrypted I have done this task. I could not add category wise average. Please make it hactoberfest accepted.

@Zircoz Zircoz self-requested a review October 19, 2022 20:09
Copy link
Copy Markdown
Contributor

@haspdecrypted haspdecrypted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Zircoz Zircoz linked an issue Oct 21, 2022 that may be closed by this pull request
1 task
Copy link
Copy Markdown
Owner

@Zircoz Zircoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the orders with "order status"=="Cancelled" are the ones which were either returned or cancelled before delivery. You'll have to filter them off before finding average.

Also, can you put these functions in a file under functions, add docstrings to those functions, call them in notebook.

@RibhavKhanna
Copy link
Copy Markdown
Author

Sure! Working on it

@RibhavKhanna
Copy link
Copy Markdown
Author

@Zircoz please check now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

average spends

3 participants