Fix: AI Check model preference not being applied#1213
Merged
davidperezgar merged 2 commits intoWordPress:trunkfrom Mar 13, 2026
Merged
Fix: AI Check model preference not being applied#1213davidperezgar merged 2 commits intoWordPress:trunkfrom
davidperezgar merged 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
|
Hello, You need to fix the tests before we can review. |
Contributor
Author
|
On it @davidperezgar |
The model preference was not being applied due to two issues: 1. method_exists() check was failing because WP_AI_Client_Prompt_Builder uses magic __call() method. Changed to directly call the method with try-catch error handling instead. 2. normalize_model_preference() was returning a nested array [['provider', 'model']] instead of the expected ['provider', 'model'] format. Removed the extra array wrapper. This ensures that when users specify a model preference like 'openai::gpt-5.4-pro', it is correctly passed to the WordPress AI client instead of falling back to the default model. Fixes WordPress#1212
raftaar1191
force-pushed
the
fix/model-preference-not-applied
branch
from
2ec35cc to
c87de09
Compare
Contributor
Author
|
Hey @davidperezgar, tests are all passing now — the PR is ready for review whenever you get a chance! |
ernilambar
approved these changes
Mar 13, 2026
davidperezgar
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The model preference was not being applied due to two issues:
method_exists() check was failing because WP_AI_Client_Prompt_Builder
uses magic __call() method. Changed to directly call the method with
try-catch error handling instead.
normalize_model_preference() was returning a nested array
[['provider', 'model']] instead of the expected ['provider', 'model']
format. Removed the extra array wrapper.
This ensures that when users specify a model preference like
'openai::gpt-5.4-pro', it is correctly passed to the WordPress AI
client instead of falling back to the default model.
Fixes #1212
Issue Video:
Recording.97.mp4
Video after adding the patch
Recording.98.mp4