Skip to content

Fixes a bug where non-control endpoint might get incorrectly STALLed #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RockyZeroFour wants to merge 1 commit into
base: feature/gd32f4-improved
Choose a base branch
from
Draft

Fixes a bug where non-control endpoint might get incorrectly STALLed #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/portable/synopsys/dwc2/dcd_dwc2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,9 +575,15 @@ void dcd_init (uint8_t rhport)
// Clear A override, force B Valid
dwc2->gotgctl = (dwc2->gotgctl & ~GOTGCTL_AVALOEN) | GOTGCTL_BVALOEN | GOTGCTL_BVALOVAL;

// Don't handle a non-zero-length status OUT handshake on GD32F4
// as due to a hardware bug the MCU can mistake a non control endpoint
// as the control endpoint and so incorrectly trigger a STALL for the
// first.
#if !TU_CHECK_MCU(OPT_MCU_GD32F4)
// If USB host misbehaves during status portion of control xfer
// (non zero-length packet), send STALL back and discard.
dwc2->dcfg |= DCFG_NZLSOHSK;
#endif

// Clear all interrupts
dwc2->gintsts |= dwc2->gintsts;
Expand Down
Loading