Prevent tick acceleration from duping items in the alchemy array#2168
Open
Saereth wants to merge 1 commit intoWayofTime:1.20.1from
Open
Prevent tick acceleration from duping items in the alchemy array#2168Saereth wants to merge 1 commit intoWayofTime:1.20.1from
Saereth wants to merge 1 commit intoWayofTime:1.20.1from
Conversation
fixes: WayofTime#1880 return false from attemptCraft() when the craft completes, so tick() takes the else branch and resets state immediately
Contributor
|
looking at the code this should work as intended you should probably remove the fixes thingy since we want to keep the issue open but tagged as "resolved in upcoming version" until the version containing the fix is released. I think we had this before but it would have been a while and Im not 100% sure about it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
return false from attemptCraft() when the craft completes, so tick() takes the else branch and resets state immediately