fix: attachable despawn vs detach order & ownership test.#3895
Merged
NoelStephensUnity merged 4 commits intodevelop-2.0.0from Mar 12, 2026
Merged
Conversation
Fixing an issue where attachables could throw an exception if an item's attachable is attached to a node and is set to detach upon ownership change and not despawn, then if the attachable item is despawned while still attached it never detaches itself from the node during a shutdown. Fixing an issue where sorting no longer is a guaranteed order.
michalChrobot
approved these changes
Mar 12, 2026
…ments-PR-84876-related
…ments-PR-84876-related
NoelStephensUnity
deleted the
fix/attachable-and-ownership-adjustments-PR-84876-related
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixing an issue where attachables could throw an exception if an item's attachable is attached to a node and is set to detach upon ownership change and not despawn, then if the attachable item is despawned while still attached it never detaches itself from the node during a shutdown.
Fixing an issue within
WhenOwnershipIsChanged_OwnershipValuesUpdateCorrectlyand use ofFindObjects.ByType<T>where it should have directly found the instance by NetworkObjectId in the targeted client's spawn list.Jira ticket
MTT-14634
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
No back port is required.