Skip to content

CI TESTING ONLY #2387

Open
josepmariapujol-unity wants to merge 1 commit intodevelopfrom
josepmariapujol-unity-patch-3
Open

CI TESTING ONLY #2387
josepmariapujol-unity wants to merge 1 commit intodevelopfrom
josepmariapujol-unity-patch-3

Conversation

@josepmariapujol-unity
Copy link
Collaborator

Description

Please fill this section with a description what the pull request is trying to address and what changes were made.

Testing status & QA

Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity:
  • Halo Effect:

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@josepmariapujol-unity josepmariapujol-unity changed the title Update EditorInputControlLayoutCache.cs CI TESTING ONLY Mar 18, 2026
Copy link
Contributor

@u-pr u-pr bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect
The code quality is excellent. Only one minor formatting suggestion was identified.

🤖 Helpful? 👍/👎

/// </remarks>
internal static class EditorInputControlLayoutCache
{

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low
Have you considered removing this blank line? It appears to have trailing whitespace and is typically not needed at the start of a class definition, which can help maintain consistent code formatting and cleanliness.

🤖 Helpful? 👍/👎

@codecov-github-com
Copy link

codecov-github-com bot commented Mar 18, 2026

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff            @@
##           develop    #2387    +/-   ##
=========================================
  Coverage    77.90%   77.91%            
=========================================
  Files          476      482     +6     
  Lines        97613    97756   +143     
=========================================
+ Hits         76048    76169   +121     
- Misses       21565    21587    +22     
Flag Coverage Δ
inputsystem_MacOS_2022.3 5.30% <ø> (-0.23%) ⬇️
inputsystem_MacOS_2022.3_project 75.42% <ø> (+0.02%) ⬆️
inputsystem_MacOS_6000.0 5.27% <ø> (-0.04%) ⬇️
inputsystem_MacOS_6000.0_project 77.33% <ø> (+0.04%) ⬆️
inputsystem_MacOS_6000.3 5.27% <ø> (-0.04%) ⬇️
inputsystem_MacOS_6000.3_project 77.32% <ø> (+0.03%) ⬆️
inputsystem_MacOS_6000.4 5.28% <ø> (-0.04%) ⬇️
inputsystem_MacOS_6000.4_project 77.33% <ø> (+0.03%) ⬆️
inputsystem_MacOS_6000.5 5.28% <ø> (-0.04%) ⬇️
inputsystem_MacOS_6000.5_project 77.32% <ø> (+0.01%) ⬆️
inputsystem_MacOS_6000.6 5.28% <ø> (-0.04%) ⬇️
inputsystem_MacOS_6000.6_project 77.33% <ø> (+0.02%) ⬆️
inputsystem_Ubuntu_2022.3_project 75.22% <ø> (+0.02%) ⬆️
inputsystem_Ubuntu_6000.0 5.28% <ø> (-0.04%) ⬇️
inputsystem_Ubuntu_6000.0_project 77.13% <ø> (+0.03%) ⬆️
inputsystem_Ubuntu_6000.3 5.28% <ø> (-0.04%) ⬇️
inputsystem_Ubuntu_6000.3_project 77.13% <ø> (+0.03%) ⬆️
inputsystem_Ubuntu_6000.4 5.28% <ø> (-0.04%) ⬇️
inputsystem_Ubuntu_6000.4_project 77.14% <ø> (+0.02%) ⬆️
inputsystem_Ubuntu_6000.5 5.28% <ø> (-0.04%) ⬇️
inputsystem_Ubuntu_6000.5_project 77.12% <ø> (+0.01%) ⬆️
inputsystem_Ubuntu_6000.6 5.28% <ø> (-0.04%) ⬇️
inputsystem_Ubuntu_6000.6_project 77.13% <ø> (+0.02%) ⬆️
inputsystem_Windows_2022.3 5.30% <ø> (-0.23%) ⬇️
inputsystem_Windows_2022.3_project 75.55% <ø> (+0.02%) ⬆️
inputsystem_Windows_6000.0 5.27% <ø> (-0.04%) ⬇️
inputsystem_Windows_6000.0_project 77.45% <ø> (+0.02%) ⬆️
inputsystem_Windows_6000.3 5.27% <ø> (-0.04%) ⬇️
inputsystem_Windows_6000.3_project 77.45% <ø> (+0.02%) ⬆️
inputsystem_Windows_6000.4 5.28% <ø> (-0.04%) ⬇️
inputsystem_Windows_6000.4_project 77.45% <ø> (+0.02%) ⬆️
inputsystem_Windows_6000.5 5.28% <ø> (-0.04%) ⬇️
inputsystem_Windows_6000.5_project 77.44% <ø> (+0.01%) ⬆️
inputsystem_Windows_6000.6 5.28% <ø> (-0.04%) ⬇️
inputsystem_Windows_6000.6_project 77.45% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nputSystem/Editor/EditorInputControlLayoutCache.cs 76.89% <ø> (ø)

... and 8 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant