CHANGE: Update CinemachineV2 to CinemachineV3#2384
CHANGE: Update CinemachineV2 to CinemachineV3#2384josepmariapujol-unity merged 5 commits intodevelopfrom
Conversation
josepmariapujol-unity
changed the title
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR introduces a significant version mismatch between the Cinemachine API used in the code and the package version specified in the manifest, which will lead to compilation errors. There are also potential issues with broken serialized field references due to the type change.
🤖 Helpful? 👍/👎
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2384 +/- ##
=========================================
Coverage 77.90% 77.91%
=========================================
Files 476 482 +6
Lines 97613 97756 +143
=========================================
+ Hits 76048 76162 +114
- Misses 21565 21594 +29 Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Won't this break 22.3 and possibly 6.0? Don't have the time to check yet but my first thought |
So far, only 6.5 test are failing due to coding obsolete API. Worth if you could check it out. |
|
No errors: |
|
No errors (22.3): |
3 participants
Description
Update from
CinemachineV2toCinemachineV3to fix internal CI errors:Before:
After:
Testing status & QA
Sample test video manually tested:
https://github.com/user-attachments/assets/3d08a71a-f7f2-4c47-9e3b-8159b171783c
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.