You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Also - please go back to the documentation from the prior PR and fix those too. Some of the items there are not accurate, if you need me to be more specific outside of the discord messages I noticed, will point them out as a git issue
Based on the review comments, I've identified several patterns that need to be addressed throughout this PR:
1. Missing const Declarations
Several JavaScript code examples are missing const declarations for variable assignments. All variable declarations should use const, let, or var for proper JavaScript syntax.
Examples needing fixes:
Lines with formData = new FormData() should be const formData = new FormData()
Lines with response = await fetch(...) should be const response = await fetch(...)
2. templateId Parameter Behavior Warning
When using the templateId parameter in AI variable generation requests, the aiHint value gets saved as the default AI prompt for that template. This behavior should either be:
Removed from examples where this side effect isn't intended
Explicitly documented with a warning about this behavior
Files affected: All JavaScript examples in ai-variable-generation.md and related script files
3. Systematic Review Needed
Please review all JavaScript code examples across the PR to ensure:
Proper variable declarations with const/let
Clear documentation of templateId side effects
Consistent coding patterns
This affects multiple files in the PR including the main documentation file and all the supporting script examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.