Add CLI search --needs-producer-review parsing tests#1556
Merged
SorraTheOrc merged 4 commits intomainfrom Apr 20, 2026
Merged
Conversation
added 4 commits
April 19, 2026 16:10
…s, and add CLI needs-producer-review yes/no parsing tests
…C3H5) - Add 6 test cases for search command --needs-producer-review flag - Tests cover true/false/yes/no values, default behavior, and invalid input - Tests verify filtering works correctly with SQLite-backed search
Member
Author
All CI checks are passingThis PR is ready for review. Posted automatically by AMPA PR Monitor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive CLI tests for the
wl search --needs-producer-reviewflag to verify boolean parsing and default semantics.Work Item
Changes
Tests Added (tests/cli/issue-status.test.ts)
Added 6 new test cases in a new
describe('search --needs-producer-review parsing')block:--needs-producer-review true- Verifies filtering returns only items withneedsProducerReview: true--needs-producer-review(no value) - Verifies default behavior treats omitted value astrue--needs-producer-review false- Verifies filtering returns only items withneedsProducerReview: false--needs-producer-review yes- Verifies human-friendlyyestoken behaves same astrue--needs-producer-review no- Verifies human-friendlynotoken behaves same asfalsemaybe) are rejected with appropriate errorTest Approach
--jsonoutput for deterministic assertionsAcceptance Criteria Met
tests/cli/that verify--needs-producer-review truereturns only items withneedsProducerReview: true--needs-producer-review falsereturns only items withneedsProducerReview: falseyes/nobehave the same astrue/falsetrueRelated Work
Review Focus
tests/cli/issue-status.test.ts