Skip to content

Add dialog parity PR checklist (WL-0MO5O00UN001OD9J)#1540

Closed
SorraTheOrc wants to merge 1 commit intomainfrom
feature/WL-0MO5O00UN001OD9J-smoke-run
Closed

Add dialog parity PR checklist (WL-0MO5O00UN001OD9J)#1540
SorraTheOrc wants to merge 1 commit intomainfrom
feature/WL-0MO5O00UN001OD9J-smoke-run

Conversation

@SorraTheOrc
Copy link
Copy Markdown
Member

Summary

Added a manual verification checklist for TUI dialogs that reviewers can use to verify dialog parity after refactoring changes.

Changes

  • Created with manual verification steps for:
    • Create Dialog (Shift+C): verify fields present, submit works
    • Update Dialog (u): verify fields, change priority, submit works
    • Visual inspection: borders, labels, positioning

Smoke-run Observations

Analysis of dialogs component and tests confirms:

  • Create dialog: 4 widgets (title, description, issue type, priority)
  • Update dialog: 4 widgets (status, stage, priority, comment)
  • All dialogs have proper borders, labels, and centered positioning
  • Tests pass: dialog-integration.test.ts (2 tests)

Testing

All tests pass: 1465 passed, 9 skipped

Work Item

  • WL-0MO5O00UN001OD9J (child of WL-0MNX4D4G8009XZNJ)

Review Focus

Please verify the checklist in is comprehensive for future dialog changes.

- Document manual verification steps for Create/Update dialogs
- Created docs/PR_CHECKLIST_DIALOG_PARITY.md
- Added smoke-run observations from tests as work item comment
- All tests pass (1465 passed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant