Open
Conversation
TheDukeDK
reviewed
Mar 19, 2021
Owner
TheDukeDK
left a comment
TheDukeDK
left a comment
There was a problem hiding this comment.
If the wait for script ensures postgres is ready to accept connections then the corresponding code should be removed from the entrypoint wrapper.sh script.
TheDukeDK
reviewed
Mar 19, 2021
Owner
TheDukeDK
left a comment
TheDukeDK
left a comment
There was a problem hiding this comment.
Rename 02-create-schema.sql to 01-create-schema.sql.
TheDukeDK
reviewed
Mar 19, 2021
TheDukeDK
approved these changes
Mar 25, 2021
Author
|
Wait merging this! |
Owner
|
@atombrella - No I won't merge it. The wrapper script needs to have the db wait stuff pulled out since it is replaced with the wait-for script. Plus we should rename the schema file to be 01. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It also replicates here now :) However,
linksis legacy docker, so it should go. I added https://github.com/eficode/wait-for as well.