Make it easy to deploy TerriaMap to GH Pages#774
Open
meiqimichelle wants to merge 2 commits intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We got a few notes from #773 about speedbumps when trying to deploy a TerriaMap to GitHub Pages.
This PR makes two changes to (hopefully) make this process a little more straightforward for future travelers. It:
Adds the
packageManagerfield topackage.jsonand pinsyarn@1.22.22so that Corepack can manage it automatically.Adds a GitHub Pages deployment workflow to this repo that uses Corepack (no npm dependency), our existing
--baseHrefgulp flag, and GitHub's official Pages deployment actions. Triggers on push tomain(or manual dispatch).Forks can enable GitHub Pages in their repo settings and this workflow will handle the rest.
Note: for this to work in this repo, we also need to check our settings. We'd need:
There may be Reasons some or all of this is not a good idea. Feedback welcome.