Skip to content

Add production Dockerfile for deployment.#530

Closed
spwoodcock wants to merge 3 commits intoTerriaJS:terriajs7from
spwoodcock:update-Dockerfile-multi-stage-prod
Closed

Add production Dockerfile for deployment.#530
spwoodcock wants to merge 3 commits intoTerriaJS:terriajs7from
spwoodcock:update-Dockerfile-multi-stage-prod

Conversation

@spwoodcock
Copy link
Copy Markdown

PR #458 was rejected, as it impacts current CI processes.

This Dockerfile is an alternative to use with production deployments.

Features:

  • Update Node 8 --> 14.
  • Multi-stage for image separation and size reduction.
  • Includes any modified packages in the build (e.g. ./packages/terriajs).
  • Contains ARGs for passing coporate proxy variables, if required.

Notes:

  • Based on official node:14-buster-slim, which is ~20mb larger than the Alpine equivalent, but allows for easier inclusion of GDAL.
  • I would suggest adding a .dockerignore to the base repo, but don't want to impact any existing CI or workflows. Something like:
**npm-debug.log
**/.vs
**/.vscode
**launch.json
**.yml
**.yaml
**Dockerfile
**.dockerignore
**.gitignore
**.env
**.editorconfig
**.eslintrc
**.gitattributes
**.gitignore
**.gitmodules
/node_modules
/architecture
/cesium-terrain-server
/ckanext-cesiumpreview
/deploy
/doc

@AnaBelgun AnaBelgun mentioned this pull request Aug 2, 2021
5 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants