Skip to content

fix(android): use equals() instead of == for string comparison in Deserializer #4552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hobostay wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(android): use equals() instead of == for string comparison in Deserializer #4552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...rk/android/src/main/java/com/tencent/mtt/hippy/serialization/compatible/Deserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ private int readJSProperties(HippyMap object, byte endTag) {
if (key instanceof Number) {
object.pushObject(String.valueOf(key), value);
} else if (key instanceof String) {
if (key == "null") {
if ("null".equals(key)) {
object.pushObject(null, value);
} else {
object.pushObject((String) key, value);
Expand All @@ -263,7 +263,7 @@ private HippyMap readJSMap() {
key = key.toString();
Object value = readValue(StringLocation.MAP_VALUE, key);
if (value != Undefined) {
if (key == "null") {
if ("null".equals(key)) {
object.pushObject(null, value);
} else {
object.pushObject((String) key, value);
Expand Down
Loading