feat(web): add repeat icon to recurring events#1506
feat(web): add repeat icon to recurring events#1506tibisabau wants to merge 10 commits intoSwitchbackTech:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a recurring-event visual indicator in the Calendar UI by displaying a repeat icon inline before event titles when an event is recurring, aligning with issue #954.
Changes:
- Import and render
RepeatIconbefore titles in grid events, all-day events, and someday sidebar events. - Remove the previous “can’t migrate recurring events” UI in
SomedayEventRectangleand replace it with icon-based indication. - Introduce new recurring detection logic in
SomedayEventRectangle(currently inconsistent with other components).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| packages/web/src/views/Calendar/components/Sidebar/SomedayTab/SomedayEvents/SomedayEventContainer/SomedayEventRectangle.tsx | Adds repeat icon and changes migrate/recurrence UI logic for someday sidebar event rows. |
| packages/web/src/views/Calendar/components/Grid/AllDayRow/AllDayEvent.tsx | Adds repeat icon before title in all-day event rendering. |
| packages/web/src/views/Calendar/components/Event/Grid/GridEvent/GridEvent.tsx | Adds repeat icon before title in time-grid event rendering. |
packages/web/src/views/Calendar/components/Event/Grid/GridEvent/GridEvent.tsx
Outdated
Show resolved
Hide resolved
.../components/Sidebar/SomedayTab/SomedayEvents/SomedayEventContainer/SomedayEventRectangle.tsx
Outdated
Show resolved
Hide resolved
.../components/Sidebar/SomedayTab/SomedayEvents/SomedayEventContainer/SomedayEventRectangle.tsx
Show resolved
Hide resolved
packages/web/src/views/Calendar/components/Grid/AllDayRow/AllDayEvent.tsx
Show resolved
Hide resolved
packages/web/src/views/Calendar/components/Event/Grid/GridEvent/GridEvent.tsx
Outdated
Show resolved
Hide resolved
tyler-dane
left a comment
There was a problem hiding this comment.
Hey @tibisabau , thanks for the submission! Please address copilot's review and tag me once you think it's in good shape according to the contribution guidelines.
.../components/Sidebar/SomedayTab/SomedayEvents/SomedayEventContainer/SomedayEventRectangle.tsx
Show resolved
Hide resolved
packages/web/src/views/Calendar/components/Event/Grid/GridEvent/GridEvent.tsx
Show resolved
Hide resolved
packages/web/src/views/Calendar/components/Grid/AllDayRow/AllDayEvent.tsx
Show resolved
Hide resolved
packages/web/src/views/Calendar/components/Grid/AllDayRow/AllDayEvent.tsx
Show resolved
Hide resolved
.../components/Sidebar/SomedayTab/SomedayEvents/SomedayEventContainer/SomedayEventRectangle.tsx
Show resolved
Hide resolved
.../components/Sidebar/SomedayTab/SomedayEvents/SomedayEventContainer/SomedayEventRectangle.tsx
Outdated
Show resolved
Hide resolved
.../components/Sidebar/SomedayTab/SomedayEvents/SomedayEventContainer/SomedayEventRectangle.tsx
Outdated
Show resolved
Hide resolved
...c/views/Calendar/components/Sidebar/SomedayTab/SomedayEvents/SomedayEventContainer/styled.ts
Show resolved
Hide resolved
packages/web/src/views/Calendar/components/Event/Grid/GridEvent/GridEvent.test.tsx
Outdated
Show resolved
Hide resolved
|
Closing due to inactivity. Happy to revisit if you get the chance |
The Copilot comments have been resolved in the latest commit. Could you please provide more information on why this PR was considered inactive? |
Hey @tibisabau , sorry for not clarifying. I closed it because I didn't know you had addressed them in a recent commit. To help me understand next time, please respond to the reviewer comment so it's more clear what the state of the PR is. Also please be sure to run tests ( |
The newest commits also addressed the test failures. The unit tests are passing locally. E2E tests are more flaky locally due to timeouts, but that happens on main locally as well. |
|
OK, thanks for clarifying. I've reopened the PR as a reminder for me to give it another look after finishing the ones I'm currently working on. |
|
Converted to draft to reflect the status of this work |
7a36376 to
1955290
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../components/Sidebar/SomedayTab/SomedayEvents/SomedayEventContainer/SomedayEventRectangle.tsx
Outdated
Show resolved
Hide resolved
.../components/Sidebar/SomedayTab/SomedayEvents/SomedayEventContainer/SomedayEventRectangle.tsx
Outdated
Show resolved
Hide resolved
.../components/Sidebar/SomedayTab/SomedayEvents/SomedayEventContainer/SomedayEventRectangle.tsx
Outdated
Show resolved
Hide resolved
...c/views/Calendar/components/Sidebar/SomedayTab/SomedayEvents/SomedayEventContainer/styled.ts
Outdated
Show resolved
Hide resolved
packages/web/src/views/Calendar/components/Event/Grid/GridEvent/GridEvent.test.tsx
Show resolved
Hide resolved
packages/web/src/views/Calendar/components/Grid/AllDayRow/AllDayEvent.test.tsx
Show resolved
Hide resolved
...onents/Sidebar/SomedayTab/SomedayEvents/SomedayEventContainer/SomedayEventRectangle.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/web/src/views/Calendar/components/Event/Grid/GridEvent/GridEvent.tsx
Outdated
Show resolved
Hide resolved
.../components/Sidebar/SomedayTab/SomedayEvents/SomedayEventContainer/SomedayEventRectangle.tsx
Show resolved
Hide resolved
.../components/Sidebar/SomedayTab/SomedayEvents/SomedayEventContainer/SomedayEventRectangle.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


Description
Added a repeat icon from @phosphor-icons/react to visually indicate recurring events across all event display components. The icon appears inline before the event title for events with recurrence rules.
Closes #954.
The code in this pull request was generated by GitHub Copilot with the Claude Sonnet 4.5 model.
Checklist if Applicable
yarn test packages/web/src/views/Calendar/components/Event/Grid/GridEvent/GridEvent.test.tsx packages/web/src/views/Calendar/components/Grid/AllDayRow/AllDayEvents.test.tsx packages/web/src/views/Calendar/components/Sidebar/SomedayTab/SomedayEvents/SomedayEventContainer/SomedayEventContainer.test.tsxyarn prettier . --write