Skip to content

feat(web): add repeat icon to recurring events#1506

Open
tibisabau wants to merge 10 commits intoSwitchbackTech:mainfrom
tibisabau:feature/add-repeat-icon
Open

feat(web): add repeat icon to recurring events#1506
tibisabau wants to merge 10 commits intoSwitchbackTech:mainfrom
tibisabau:feature/add-repeat-icon

Conversation

@tibisabau
Copy link
Contributor

Description

Added a repeat icon from @phosphor-icons/react to visually indicate recurring events across all event display components. The icon appears inline before the event title for events with recurrence rules.

Closes #954.

The code in this pull request was generated by GitHub Copilot with the Claude Sonnet 4.5 model.

Checklist if Applicable

  • The tests passed – yarn test packages/web/src/views/Calendar/components/Event/Grid/GridEvent/GridEvent.test.tsx packages/web/src/views/Calendar/components/Grid/AllDayRow/AllDayEvents.test.tsx packages/web/src/views/Calendar/components/Sidebar/SomedayTab/SomedayEvents/SomedayEventContainer/SomedayEventContainer.test.tsx
  • Linting passed – yarn prettier . --write
  • Documentation has been added
  • CHANGELOG.md has been updated

Copilot AI review requested due to automatic review settings March 3, 2026 21:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a recurring-event visual indicator in the Calendar UI by displaying a repeat icon inline before event titles when an event is recurring, aligning with issue #954.

Changes:

  • Import and render RepeatIcon before titles in grid events, all-day events, and someday sidebar events.
  • Remove the previous “can’t migrate recurring events” UI in SomedayEventRectangle and replace it with icon-based indication.
  • Introduce new recurring detection logic in SomedayEventRectangle (currently inconsistent with other components).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
packages/web/src/views/Calendar/components/Sidebar/SomedayTab/SomedayEvents/SomedayEventContainer/SomedayEventRectangle.tsx Adds repeat icon and changes migrate/recurrence UI logic for someday sidebar event rows.
packages/web/src/views/Calendar/components/Grid/AllDayRow/AllDayEvent.tsx Adds repeat icon before title in all-day event rendering.
packages/web/src/views/Calendar/components/Event/Grid/GridEvent/GridEvent.tsx Adds repeat icon before title in time-grid event rendering.

Copy link
Contributor

@tyler-dane tyler-dane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tibisabau , thanks for the submission! Please address copilot's review and tag me once you think it's in good shape according to the contribution guidelines.

@tibisabau tibisabau requested a review from tyler-dane March 4, 2026 20:57
Copilot AI review requested due to automatic review settings March 5, 2026 10:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

@tyler-dane
Copy link
Contributor

Closing due to inactivity. Happy to revisit if you get the chance

@tyler-dane tyler-dane closed this Mar 13, 2026
@tibisabau
Copy link
Contributor Author

Closing due to inactivity. Happy to revisit if you get the chance

The Copilot comments have been resolved in the latest commit. Could you please provide more information on why this PR was considered inactive?

@tyler-dane
Copy link
Contributor

Closing due to inactivity. Happy to revisit if you get the chance

The Copilot comments have been resolved in the latest commit. Could you please provide more information on why this PR was considered inactive?

Hey @tibisabau , sorry for not clarifying. I closed it because I didn't know you had addressed them in a recent commit. To help me understand next time, please respond to the reviewer comment so it's more clear what the state of the PR is.

Also please be sure to run tests (yarn test, yarn test web, etc) locally. I might be wrong, but I vaguely remember them failing also.

@tibisabau
Copy link
Contributor Author

Closing due to inactivity. Happy to revisit if you get the chance

The Copilot comments have been resolved in the latest commit. Could you please provide more information on why this PR was considered inactive?

Hey @tibisabau , sorry for not clarifying. I closed it because I didn't know you had addressed them in a recent commit. To help me understand next time, please respond to the reviewer comment so it's more clear what the state of the PR is.

Also please be sure to run tests (yarn test, yarn test web, etc) locally. I might be wrong, but I vaguely remember them failing also.

The newest commits also addressed the test failures. The unit tests are passing locally. E2E tests are more flaky locally due to timeouts, but that happens on main locally as well.

@tyler-dane tyler-dane reopened this Mar 20, 2026
@tyler-dane
Copy link
Contributor

OK, thanks for clarifying.

I've reopened the PR as a reminder for me to give it another look after finishing the ones I'm currently working on.

Copy link
Contributor

@tyler-dane tyler-dane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

A few styling issues:

  • We're moving away from styled-components, so styles should use tailwind
  • The icon pushes the title down a row, which is problematic for shorter events (create a 15-min event for example)

#1142 #1382

@tyler-dane tyler-dane marked this pull request as draft March 22, 2026 03:18
@tyler-dane
Copy link
Contributor

Converted to draft to reflect the status of this work

Copilot AI review requested due to automatic review settings March 22, 2026 08:43
@tibisabau tibisabau force-pushed the feature/add-repeat-icon branch from 7a36376 to 1955290 Compare March 22, 2026 08:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tibisabau tibisabau marked this pull request as ready for review March 22, 2026 08:58
@tibisabau tibisabau requested review from Copilot and tyler-dane March 22, 2026 08:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tyler-dane
Copy link
Contributor

Screenshot 2026-03-22 at 6 19 44 PM

Repeat icon is now not appearing on either someday or regular events 🤔

@tyler-dane tyler-dane marked this pull request as draft March 23, 2026 01:20
Copy link
Contributor

@tyler-dane tyler-dane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous comment

Copilot AI review requested due to automatic review settings March 23, 2026 08:21
@tibisabau tibisabau marked this pull request as ready for review March 23, 2026 08:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add repeat icon to recurring events

3 participants