The initial implementation of advanced test environment.#4
Draft
xgreenx wants to merge 1 commit intorelease/3.3.1from
Draft
The initial implementation of advanced test environment.#4xgreenx wants to merge 1 commit intorelease/3.3.1from
xgreenx wants to merge 1 commit intorelease/3.3.1from
Conversation
16 tasks
h4x3rotab
reviewed
Oct 19, 2022
Comment on lines
+240
to
+242
| if flags.is_reverted() { | ||
| panic!("the off-chain env does not implement revert in `seal_return_value`") | ||
| } |
There was a problem hiding this comment.
Just tested it out in a relatively large project. This is the only problem I've encountered so far. If this one is not implemented, if any function returns an Err, the unit test will be interrupted by the panic. So there's no way to test any error case like below:
assert_eq!(contract.func(), Err(Error::SomeErr));
This was referenced Jan 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.