Release GVL during Zstd.decompress to enable multi-threaded decompression#133
Closed
Release GVL during Zstd.decompress to enable multi-threaded decompression#133
Conversation
…sion Changed decode_one_frame to use zstd_stream_decompress with GVL release instead of calling ZSTD_decompressStream directly. This allows multiple Ruby threads to decompress independent data in parallel. Performance improvement with 4 threads: - Before: ~1.41s (single-threaded, CPU ~100%) - After: ~0.47s (parallel, ~3x speedup) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
Author
|
see #112 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the multi-threaded decompression performance issue by releasing the GVL (Global VM Lock) during
Zstd.decompressoperations.Changes
decode_one_frameinext/zstdruby/zstdruby.cto usezstd_stream_decompresswith GVL release instead of callingZSTD_decompressStreamdirectlyPerformance Improvement
Before (with GVL held):
After (with GVL released):
Technical Details
The fix aligns
Zstd.decompressbehavior with:Zstd.compress(already releases GVL viazstd_compress(..., false))StreamingDecompress#decompress(already releases GVL viazstd_stream_decompress(..., false))This enables decompressing multiple independent compressed data streams in parallel across multiple CPU cores.
Test Plan
🤖 Generated with Claude Code