Skip to content

updates in SNZB-04PR2 and SNZB-04P fingerprints (WWSTCERT-10731, WWSTCERT-10704)#2909

Open
KKlimczukS wants to merge 2 commits intomainfrom
sonoff_door_window_sensors_fix
Open

updates in SNZB-04PR2 and SNZB-04P fingerprints (WWSTCERT-10731, WWSTCERT-10704)#2909
KKlimczukS wants to merge 2 commits intomainfrom
sonoff_door_window_sensors_fix

Conversation

@KKlimczukS
Copy link
Copy Markdown
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

fixes in fingerprint -> device will use contact-battery-tamper device profile that was introduced in #2539

Summary of Completed Tests

@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

Test Results

   72 files    507 suites   0s ⏱️
2 786 tests 2 785 ✅ 0 💤 0 ❌ 1 🔥
4 688 runs  4 687 ✅ 0 💤 0 ❌ 1 🔥

For more details on these errors, see this check.

Results for commit c6e97d9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

File Coverage
All files 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/lazy_load_subdriver.lua 57%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/init.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-contact/src/frient/frient-vibration/init.lua 87%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against c6e97d9

Copy link
Copy Markdown
Contributor

@cjswedes cjswedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need to be updated I think Actually just needs a fix that will get in today to get the tests passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants