Open
Conversation
Test Results 72 files 508 suites 0s ⏱️ For more details on these errors, see this check. Results for commit b3cc43b. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against b3cc43b |
nickolas-deboom
force-pushed
the
feature/matter-soil-sensor
branch
from
5abb504 to
eb50abd
Compare
|
Invitation URL: |
hcarter-775
reviewed
Feb 5, 2026
hcarter-775
reviewed
Feb 5, 2026
nickolas-deboom
force-pushed
the
feature/matter-soil-sensor
branch
2 times, most recently
from
a7fcbb4 to
09c0f55
Compare
nickolas-deboom
commented
Feb 5, 2026
| clusters.RadonConcentrationMeasurement.attributes.MeasuredValue, | ||
| clusters.RadonConcentrationMeasurement.attributes.MeasurementUnit, | ||
| }, | ||
| [capabilities.relativeHumidityMeasurement.ID] = { |
Contributor
Author
There was a problem hiding this comment.
This was a duplicate entry
nickolas-deboom
commented
Feb 5, 2026
| -- remove leading "-" | ||
| profile_name = string.sub(profile_name, 2) | ||
|
|
||
| device.log.info_with({hub_logs=true}, string.format("Updating device profile to %s.", profile_name)) |
Contributor
Author
There was a problem hiding this comment.
I removed this log because I realized this is now logged by the lua libs
nickolas-deboom
force-pushed
the
feature/matter-soil-sensor
branch
from
d3ae5af to
01d94a4
Compare
|
Duplicate profile check: Warning - duplicate profiles detected. |
nickolas-deboom
force-pushed
the
feature/matter-soil-sensor
branch
from
8e21d60 to
a2e702f
Compare
nickolas-deboom
force-pushed
the
feature/matter-soil-sensor
branch
from
a2e702f to
0de69b8
Compare
nickolas-deboom
force-pushed
the
feature/matter-soil-sensor
branch
from
0de69b8 to
8bff4f6
Compare
hcarter-775
reviewed
Apr 21, 2026
| ib.data.elements.min_measured_value == nil or ib.data.elements.min_measured_value.value == nil or | ||
| ib.data.elements.max_measured_value == nil or ib.data.elements.max_measured_value.value == nil or | ||
| ib.data.elements.min_measured_value.value >= ib.data.elements.max_measured_value.value then | ||
| device.log.warn_with({hub_logs = true}, "Device reported invalid soil moisture limits") |
Contributor
There was a problem hiding this comment.
Can you expand on this warning to give slightly more info?
Comment on lines
+97
to
+98
| sensor_utils.set_field_for_endpoint(device, fields.SOIL_LIMIT_MIN, ib.endpoint_id, ib.data.elements.min_measured_value.value) | ||
| sensor_utils.set_field_for_endpoint(device, fields.SOIL_LIMIT_MAX, ib.endpoint_id, ib.data.elements.max_measured_value.value) |
Contributor
There was a problem hiding this comment.
Should we have sanity checks here you think?
| if device:supports_capability(capabilities.relativeHumidityMeasurement) then | ||
| profile_name = profile_name .. "-humidity" | ||
| -- Soil Sensor fingerprints to the humidity profile, so we should also check for | ||
| -- TemperatureMeasurement, which is an optional cluster for this device type. |
Contributor
There was a problem hiding this comment.
might be worth adding a TODO comment about having a new category for soil sensor. Otherwise this kinda doesn't make sense why there'd be a separate profile
Comment on lines
+85
to
+86
| update_device_profile() | ||
| test.wait_for_events() |
Contributor
There was a problem hiding this comment.
I suggest we break this into a separate test. I don't think we need to test the do configure profile update in a relative humidity report test. I think this makes changing tests later more difficult. Same comment for other tests.
Basically I think we should have this profile update be its own test, separate from everything else.
nickolas-deboom
force-pushed
the
feature/matter-soil-sensor
branch
from
c744895 to
b3cc43b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the Soil Sensor device type, introduced with Matter 1.5.