refactor: introduce de.speedbanking:iban-commons#160
Merged
spannm merged 1 commit intoSkillPanel:masterfrom Mar 27, 2026
Merged
refactor: introduce de.speedbanking:iban-commons#160spannm merged 1 commit intoSkillPanel:masterfrom
spannm merged 1 commit intoSkillPanel:masterfrom
Conversation
Simplifies the IBAN generation logic by migrating from iban4j to the more performant iban-commons library. This change streamlines the DefaultIBANProvider by offloading random IBAN generation directly to the new library's RandomIban utility. Key changes: - Switched dependency from org.iban4j:iban4j to de.speedbanking:iban-commons - Refactored DefaultIBANProvider to use IbanRegistry and RandomIban, eliminating the manual Iban.Builder ceremony - Removed several redundant fields and setters (accountNumber, bankCode, branchCode, nationalCheckDigit) from IBANProvider and DefaultIBANProvider, favoring the library's internal generation - Simplified the IBAN data object by removing unused fields like identificationNumber, accountType, and ownerAccountType - Updated IBANProperties to map LanguageCodes directly to IbanRegistry constants - Updated test suite to use IbanValidator for verification link: https://www.speedbanking.de/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the IBAN generation logic by migrating from iban4j to the more performant iban-commons library. This change streamlines the DefaultIBANProvider by offloading random IBAN generation directly to the new library's RandomIban utility.
Key changes:
link: https://www.speedbanking.de/