Fix corrupted GIMPLE for const-compound-assignment#4520
Open
Islam-Imad wants to merge 1 commit intoRust-GCC:masterfrom
Open
Fix corrupted GIMPLE for const-compound-assignment#4520Islam-Imad wants to merge 1 commit intoRust-GCC:masterfrom
Islam-Imad wants to merge 1 commit intoRust-GCC:masterfrom
Conversation
Contributor
Author
|
cc @powerboat9 |
powerboat9
approved these changes
Apr 12, 2026
Islam-Imad
force-pushed
the
fix-const-compound-assignment
branch
from
4c1a8f6 to
94b9cdc
Compare
Contributor
Author
|
ping ? |
Collaborator
|
Could you reword the commit message a bit, before I merge?
Also,
should probably start with a capital F and end with a period. |
Islam-Imad
force-pushed
the
fix-const-compound-assignment
branch
from
94b9cdc to
44e0394
Compare
Contributor
Author
is it good right now or we need to update it again ? |
Collaborator
|
Pretty much, just a small typo ( |
CompoundAssignmentExpr codegen was missing the final assignment statement when it was evaluated in a const context. gcc/rust/ChangeLog: * backend/rust-compile-expr.cc (CompileExpr::visit): Emit the missing assignment for CompoundAssignmentExpr. gcc/testsuite/ChangeLog: * rust/compile/const-compound-assignment.rs: New test. * rust/execute/const-compound-assignment.rs: New test. Signed-off-by: Islam-Imad <islamimad404@gmail.com>
Islam-Imad
force-pushed
the
fix-const-compound-assignment
branch
from
44e0394 to
cad9d90
Compare
Contributor
Author
|
gentle ping :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we miss to add the assignment statement.
closes #4519