Use Jekyll and Grunt to avoid GitHub API calls#21
Open
gregoryjscott wants to merge 8 commits intoResourceDataInc:gh-pagesfrom
Open
Use Jekyll and Grunt to avoid GitHub API calls#21gregoryjscott wants to merge 8 commits intoResourceDataInc:gh-pagesfrom
gregoryjscott wants to merge 8 commits intoResourceDataInc:gh-pagesfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure I even like this idea but it was an interesting experiment so I thought I would at least share it. This would fix #19. You can view the result here.
This switches the site to use Jekyll and adds a custom Jekyll plugin that generates a
data.jsfile that contains all the geojson data. The index.html file referencesdata.js. This works great, however GitHub doesn't allow custom Jekyll plugins in GitHub pages (using GitHub's built in support for Jekyll) so we're stuck with generating the content first and then pushing to the gh-pages branch. So, I added Grunt and the grunt-gh-pages plugin to automate that part.To get this to work right, we'd need to set the default branch back to
masterand do PRs onmaster. The deployments steps would be:master.jekyll build.grunt gh-pages.The last two steps could be setup in Travis so that we'd only need to merge PRs to master and everything else would be automated.
Tasks
masteras default branchmaster?masterbranch