Skip to content

[ROCm] support topk_softplus for all number of experts#899

Open
tjtanaa wants to merge 2 commits intoROCm:hexwang/dsv4_adaptfrom
tjtanaa:hexwang/dsv4_adapt
Open

[ROCm] support topk_softplus for all number of experts#899
tjtanaa wants to merge 2 commits intoROCm:hexwang/dsv4_adaptfrom
tjtanaa:hexwang/dsv4_adapt

Conversation

@tjtanaa
Copy link
Copy Markdown

@tjtanaa tjtanaa commented Apr 25, 2026

Purpose

Add full support of topk_softplus on ROCm

Test Plan

Temporary widen the num_expert cases. I didn't widen the case to align with CUDA and also to reduce the unit test duration.

Test Result

================ 3240 passed, 16 warnings in 1297.93s (0:21:37) ================


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

tjtanaa added 2 commits April 25, 2026 05:52
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant