[ROCm] support topk_softplus for all number of experts#899
Open
tjtanaa wants to merge 2 commits intoROCm:hexwang/dsv4_adaptfrom
Open
[ROCm] support topk_softplus for all number of experts#899tjtanaa wants to merge 2 commits intoROCm:hexwang/dsv4_adaptfrom
tjtanaa wants to merge 2 commits intoROCm:hexwang/dsv4_adaptfrom
Conversation
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add full support of topk_softplus on ROCm
Test Plan
Temporary widen the num_expert cases. I didn't widen the case to align with CUDA and also to reduce the unit test duration.
Test Result
================ 3240 passed, 16 warnings in 1297.93s (0:21:37) ================Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.