Support biased SwiGLU in MXFP4 MoE#3735
Open
XiaobingSuper wants to merge 1 commit intoROCm:developfrom
Open
Conversation
Add bias-aware SwiGLU handling to the MXFP4 MoE gridwise paths and keep split-k epilogues from accumulating stale data when k_batch is one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add bias-aware SwiGLU handling to the MXFP4 MoE gridwise paths and keep split-k epilogues from accumulating stale data when k_batch is one.
Proposed changes
swiglustep_and_mulhandling for MXFP4 MoE with GPT-OSS style SwiGLU clamp/alpha behavior.k_batch == 1stores instead of accumulating stale output.Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered