Skip to content

Disable all UB layer tests for gfx942 #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alextmagro merged 1 commit into from
Apr 29, 2026
+2 −2
Merged

Disable all UB layer tests for gfx942 #567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/pytorch/distributed/test_comm_gemm_overlap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,9 @@ def _run_layer_with_overlap(
pytest.skip("Bulk overlap is not yet supported on HIP/ROCm.")
# On gfx942, non-determinism across the 8 XCDs causes small jitter that compounds
# This should not affect training convergence, but creates larger numerical differences.
# TODO: Fix gfx942 issues arising from deterministic bwd attention and other jitter
if (IS_HIP_EXTENSION
and get_device_compute_capability() < (9, 5)
and layer_type == te.TransformerLayer.__name__):
and get_device_compute_capability() < (9, 5)):
pytest.skip("TransformerLayer overlap can exceed numerical tolerance on pre-MI350 due to jitter.")
test_path = TEST_ROOT / "run_layer_with_overlap.py"
test_cmd = LAUNCH_CMD + [
Expand Down